Summary
The coding-standards collection stores its agents and prompts under .github/agents/code-review/ and .github/prompts/code-review/ instead of .github/agents/coding-standards/ and .github/prompts/coding-standards/. This is the only collection that violates the collection-to-folder naming convention. Instructions already use the correct folder (.github/instructions/coding-standards/).
This causes the plugin output to have an inconsistent structure where agents/code-review/ and commands/code-review/ appear alongside instructions/coding-standards/.
Discovery
This discrepancy was discovered during review work on PR #1174 (standards code review agent). The functional-code-review agent was placed in .github/agents/code-review/ before the collection-to-folder naming convention was fully enforced, and was never corrected. PR #1174 adds several more files to the same folder, making now the right time to fix the convention violation on main before that PR can land cleanly.
Files to Move
.github/agents/code-review/functional-code-review.agent.md → .github/agents/coding-standards/
.github/prompts/code-review/functional-code-review.prompt.md → .github/prompts/coding-standards/
Path References to Update (8 total)
| File |
Changes |
collections/coding-standards.collection.yml |
2 path updates (lines 19, 22) |
collections/hve-core-all.collection.yml |
2 path updates (lines 13, 135) |
.github/skills/installer/hve-core-installer/SKILL.md |
4 path updates (lines 392, 403, 477, 488) |
Auto-Regenerated (via npm run plugin:generate)
plugins/coding-standards/ — plugin.json, symlinks, README
plugins/hve-core-all/ — plugin.json, symlinks, README
extension/README.coding-standards.md and extension/README.hve-core-all.md
Notes
- The
code-review tag in coding-standards.collection.yml is retained — it's a valid categorization tag, not a folder name.
- No
.github/instructions/code-review/ or .github/skills/code-review/ directories exist on main.
Acceptance Criteria
Summary
The
coding-standardscollection stores its agents and prompts under.github/agents/code-review/and.github/prompts/code-review/instead of.github/agents/coding-standards/and.github/prompts/coding-standards/. This is the only collection that violates the collection-to-folder naming convention. Instructions already use the correct folder (.github/instructions/coding-standards/).This causes the plugin output to have an inconsistent structure where
agents/code-review/andcommands/code-review/appear alongsideinstructions/coding-standards/.Discovery
This discrepancy was discovered during review work on PR #1174 (standards code review agent). The
functional-code-reviewagent was placed in.github/agents/code-review/before the collection-to-folder naming convention was fully enforced, and was never corrected. PR #1174 adds several more files to the same folder, making now the right time to fix the convention violation onmainbefore that PR can land cleanly.Files to Move
.github/agents/code-review/functional-code-review.agent.md→.github/agents/coding-standards/.github/prompts/code-review/functional-code-review.prompt.md→.github/prompts/coding-standards/Path References to Update (8 total)
collections/coding-standards.collection.ymlcollections/hve-core-all.collection.yml.github/skills/installer/hve-core-installer/SKILL.mdAuto-Regenerated (via
npm run plugin:generate)plugins/coding-standards/— plugin.json, symlinks, READMEplugins/hve-core-all/— plugin.json, symlinks, READMEextension/README.coding-standards.mdandextension/README.hve-core-all.mdNotes
code-reviewtag incoding-standards.collection.ymlis retained — it's a valid categorization tag, not a folder name..github/instructions/code-review/or.github/skills/code-review/directories exist onmain.Acceptance Criteria
code-reviewfolder paths remain in source-of-truth filesnpm run plugin:generateproducesagents/coding-standards/andcommands/coding-standards/npm run lint:allpassesnpm run plugin:validatepasses