Skip to content

Commit d5ff757

Browse files
committed
docs: address PR review feedback on bot-guard rationale and Dependabot workflow PRs
- pr-review.md: clarify that dependabot[bot] is skipped because dependency-pr-review owns automated review for dependency bumps (RI-1). - CONTRIBUTING.md: document that Dependabot PRs bumping action SHAs inside .github/workflows/*.yml require manual maintainer review because GitHub strips secrets from workflow-file PRs (RI-3).
1 parent 7605608 commit d5ff757

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

.github/workflows/pr-review.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ Check the PR state from the event context.
6767
* The PR author (`github.event.pull_request.user.login`) is `dependabot[bot]`
6868
or `github-actions[bot]`: call `noop` with message "Skipping: PR authored by
6969
bot." Keep this list aligned with the `skip-bots` frontmatter entry above.
70+
Dependabot PRs are handed off to the `dependency-pr-review` workflow, which
71+
owns automated review for dependency bumps; this guard prevents duplicate
72+
review from `pr-review`.
7073

7174
**Failure to call `noop` when no review action is taken will cause workflow failure.**
7275

CONTRIBUTING.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ We strongly recommend using the provided DevContainer, which comes pre-configure
9191
* [Artifact Types](#artifact-types)
9292
* [Essential Resources](#essential-resources)
9393
* [Quick Reference](#quick-reference)
94+
* [Dependabot Pull Requests](#dependabot-pull-requests)
9495
* [Pull Request Inactivity Policy](#pull-request-inactivity-policy)
9596
* [Active Pull Requests](#active-pull-requests)
9697
* [Draft Pull Requests](#draft-pull-requests)
@@ -242,6 +243,12 @@ Before contributing AI artifacts, review these resources:
242243
* Prompts directory: [`.github/prompts/`](./.github/prompts/)
243244
* Skills directory: [`.github/skills/`](./.github/skills/)
244245

246+
## Dependabot Pull Requests
247+
248+
Dependabot PRs are reviewed automatically by the `dependency-pr-review` workflow for most dependency manifests (`package.json`, `package-lock.json`, `requirements.txt`, `pyproject.toml`, and `.devcontainer/**`).
249+
250+
PRs that bump pinned action SHAs inside `.github/workflows/*.yml` are **not** covered by the automated review because GitHub strips secrets from workflow-file PRs, which prevents the workflow from running. Maintainers must review and merge those workflow-file bumps manually, verifying SHA pinning, upstream release notes, and license compatibility before approval.
251+
245252
## Pull Request Inactivity Policy
246253

247254
Pull requests that remain inactive accumulate merge conflicts and delay feedback loops. This section defines closure timelines for inactive PRs. Automation that enforces this policy is a separate effort that references these thresholds.

0 commit comments

Comments
 (0)