Skip to content

Commit 712b0b7

Browse files
agreaves-msagreaves-ms
authored
refactor: migrate chatmodes to agents architecture (#210)
# Pull Request ## Description This PR completes a comprehensive refactoring of the HVE-Core prompt engineering infrastructure, renaming "chatmodes" to "agents" throughout the codebase and introducing new workflow capabilities. ### Key Changes **Terminology Migration:** - Renamed `.github/chatmodes/` directory to `.github/agents/` - Migrated all `.chatmode.md` files to `.agent.md` extension - Updated all documentation, prompts, and instructions to use "agent" terminology **New Documentation:** - Added [.github/README.md](.github/README.md) providing comprehensive documentation for GitHub Copilot Custom Agents - Created [docs/contributing/skills.md](docs/contributing/skills.md) for skill package contribution guidelines - Added [docs/templates/security-plan-template.md](docs/templates/security-plan-template.md) for security plan generation **Workflow Enhancements:** - Added [task-implement.prompt.md](.github/prompts/task-implement.prompt.md) for plan execution with stop controls - Enhanced [task-research.prompt.md](.github/prompts/task-research.prompt.md) with subagent dispatch patterns - Streamlined [task-plan.prompt.md](.github/prompts/task-plan.prompt.md) for implementation planning - Added [prompt-refactor.prompt.md](.github/prompts/prompt-refactor.prompt.md) for iterative artifact improvement **Skills Infrastructure:** - Added skills section to documentation and extension packaging - Created [skill-frontmatter.schema.json](scripts/linting/schemas/skill-frontmatter.schema.json) for validation - Updated schema mapping to include skill files **Extension Updates:** - Updated extension packaging to use agents instead of chatmodes - Added docs/templates to packaging for agent reference - Updated Prepare-Extension.ps1 to discover agents from new location **Configuration:** - Updated VS Code settings to reference `.github/agents/` directory ## Related Issue(s) N/A ## Type of Change Select all that apply: **Code & Documentation:** - [ ] Bug fix (non-breaking change fixing an issue) - [ ] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature causing existing functionality to change) - [x] Documentation update **Infrastructure & Configuration:** - [ ] GitHub Actions workflow - [x] Linting configuration (markdown, PowerShell, etc.) - [ ] Security configuration - [ ] DevContainer configuration - [ ] Dependency update **AI Artifacts:** - [x] Reviewed contribution with `prompt-builder` agent and addressed all feedback - [x] Copilot instructions (`.github/instructions/*.instructions.md`) - [x] Copilot prompt (`.github/prompts/*.prompt.md`) - [x] Copilot agent (`.github/agents/*.agent.md`) > **Note for AI Artifact Contributors**: > > - **Agents**: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review `.github/agents/` before creating new ones. > - **Model Versions**: Only contributions targeting the **latest Anthropic and OpenAI models** will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected. > - See [Agents Not Accepted](../docs/contributing/custom-agents.md#agents-not-accepted) and [Model Version Requirements](../docs/contributing/ai-artifacts-common.md#model-version-requirements). **Other:** - [x] Script/automation (`.ps1`, `.sh`, `.py`) - [ ] Other (please describe): ## Sample Prompts (for AI Artifact Contributions) **User Request:** Use the new task-implement prompt to execute a plan: ```text /task-implement ``` Or refactor a prompt artifact: ```text /prompt-refactor file=.github/prompts/task-plan.prompt.md ``` **Execution Flow:** 1. `task-implement` reads plans from `.copilot-tracking/plans/` and `.copilot-tracking/details/` 2. Executes implementation steps with stop controls for validation 3. Records changes in `.copilot-tracking/changes/` **Output Artifacts:** - Implementation changes to target files - Change records in `.copilot-tracking/changes/*.md` **Success Indicators:** - All agent files are discoverable in VS Code chat mode picker - Prompt invocations work correctly after rename - Extension preparation script discovers agents from new location - Frontmatter schemas validate new agent files For detailed contribution requirements, see: - **Common Standards**: [docs/contributing/ai-artifacts-common.md](../docs/contributing/ai-artifacts-common.md) - Shared standards for XML blocks, markdown quality, RFC 2119, validation, and testing - **Agents**: [docs/contributing/custom-agents.md](../docs/contributing/custom-agents.md) - Agent configurations with tools and behavior patterns - **Prompts**: [docs/contributing/prompts.md](../docs/contributing/prompts.md) - Workflow-specific guidance with template variables - **Instructions**: [docs/contributing/instructions.md](../docs/contributing/instructions.md) - Technology-specific standards with glob patterns ## Testing Testing was performed manually by: 1. Verifying all agent files are discoverable in VS Code chat mode picker 2. Confirming prompt invocations work correctly after rename 3. Testing extension preparation script discovers agents from new location 4. Validating frontmatter schemas apply to new agent files ## Checklist ### Required Checks - [x] Documentation is updated (if applicable) - [x] Files follow existing naming conventions - [x] Changes are backwards compatible (if applicable) ### AI Artifact Contributions - [x] Used `/prompt-analyze` to review contribution - [x] Addressed all feedback from `prompt-builder` review - [x] Verified contribution follows common standards and type-specific requirements ### Required Automated Checks The following validation commands must pass before merging: - [x] Markdown linting: `npm run lint:md` - [x] Spell checking: `npm run spell-check` - [x] Frontmatter validation: `npm run lint:frontmatter` - [x] Link validation: `npm run lint:md-links` - [x] PowerShell analysis: `npm run lint:ps` ## Security Considerations - [x] This PR does not contain any sensitive or NDA information - [x] Any new dependencies have been reviewed for security issues - [x] Security-related scripts follow the principle of least privilege ## Additional Notes ### GHCP Artifact Maturity This PR includes GHCP (GitHub Copilot) artifacts with maturity levels affecting release channels. | File | Type | Maturity | Notes | |------|------|----------|-------| | `ado-prd-to-wit.agent.md` | Agent | ✅ stable | All builds | | `adr-creation.agent.md` | Agent | ✅ stable | All builds | | `arch-diagram-builder.agent.md` | Agent | ✅ stable | All builds | | `brd-builder.agent.md` | Agent | ✅ stable | All builds | | `gen-data-spec.agent.md` | Agent | ✅ stable | All builds | | `gen-jupyter-notebook.agent.md` | Agent | ✅ stable | All builds | | `gen-streamlit-dashboard.agent.md` | Agent | ✅ stable | All builds | | `github-issue-manager.agent.md` | Agent | ✅ stable | All builds | | `pr-review.agent.md` | Agent | ✅ stable | All builds | | `prd-builder.agent.md` | Agent | ✅ stable | All builds | | `prompt-builder.agent.md` | Agent | ✅ stable | All builds | | `rpi-agent.agent.md` | Agent | ✅ stable | All builds | | `security-plan-creator.agent.md` | Agent | ✅ stable | All builds | | `task-implementor.agent.md` | Agent | ✅ stable | All builds | | `task-planner.agent.md` | Agent | ✅ stable | All builds | | `task-researcher.agent.md` | Agent | ✅ stable | All builds | | `test-streamlit-dashboard.agent.md` | Agent | ✅ stable | All builds | | `prompt-refactor.prompt.md` | Prompt | ✅ stable | All builds | | `task-implement.prompt.md` | Prompt | ✅ stable | All builds | | `prompt-analyze.prompt.md` | Prompt | ✅ stable | All builds | | `prompt-builder.instructions.md` | Instructions | ✅ stable | All builds | | `terraform.instructions.md` | Instructions | ✅ stable | All builds | --- *🤖 Crafted with precision by ✨Copilot following brilliant human instruction, then carefully refined by our team of discerning human reviewers.*
1 parent 54dd959 commit 712b0b7

90 files changed

Lines changed: 4655 additions & 4873 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.cspell/general-technical.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1327,6 +1327,8 @@ Upselling
13271327

13281328
# Development & DevOps
13291329
agile
1330+
choco
1331+
chocolatey
13301332
cicd
13311333
devops
13321334
scrum
@@ -1340,6 +1342,8 @@ shellcheck
13401342
nslookup
13411343
journalctl
13421344
vimdiff
1345+
virtualenv
1346+
venv
13431347
mergetool
13441348
gitmessage
13451349
pipefail

‎.github/ISSUE_TEMPLATE/bug-report.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ body:
1616
options:
1717
- Instruction Files
1818
- Prompts
19-
- Chat Modes/Agents
19+
- Custom Agents
2020
- Scripts
2121
- Documentation
2222
- Other

.github/ISSUE_TEMPLATE/chatmode-request.yml renamed to .github/ISSUE_TEMPLATE/custom-agent-request.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
name: Chat Mode or Agent Request
2-
description: Request a new chat mode, agent, or slash command
3-
title: "[Chat Mode]: "
4-
labels: ["chat-mode", "needs-triage"]
1+
name: Custom Agent Request
2+
description: Request a new custom agent or slash command
3+
title: "[Custom Agent]: "
4+
labels: ["custom-agent", "needs-triage"]
55
body:
66
- type: markdown
77
attributes:
88
value: |
9-
Request a new chat mode, custom agent, or slash command for GitHub Copilot.
9+
Request a new custom agent or slash command for GitHub Copilot.
1010
1111
- type: input
1212
id: name
1313
attributes:
14-
label: Chat Mode/Agent Name
14+
label: Custom Agent Name
1515
description: What should this be called?
1616
placeholder: e.g., "/security-review"
1717
validations:
@@ -23,8 +23,8 @@ body:
2323
label: Type
2424
description: What type of enhancement is this?
2525
options:
26-
- Chat Mode
2726
- Custom Agent
27+
- Slash Command
2828
- Other
2929
validations:
3030
required: true

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,16 @@ Select all that apply:
2727

2828
**AI Artifacts:**
2929

30-
- [ ] Reviewed contribution with `prompt-builder` chatmode and addressed all feedback
30+
- [ ] Reviewed contribution with `prompt-builder` agent and addressed all feedback
3131
- [ ] Copilot instructions (`.github/instructions/*.instructions.md`)
3232
- [ ] Copilot prompt (`.github/prompts/*.prompt.md`)
33-
- [ ] Copilot chatmode (`.github/chatmodes/*.chatmode.md`)
33+
- [ ] Copilot agent (`.github/agents/*.agent.md`)
3434

3535
> **Note for AI Artifact Contributors**:
3636
>
37-
> - **Chatmodes**: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation chatmodes likely already exist. Review `.github/chatmodes/` before creating new ones.
37+
> - **Agents**: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review `.github/agents/` before creating new ones.
3838
> - **Model Versions**: Only contributions targeting the **latest Anthropic and OpenAI models** will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
39-
> - See [Chatmodes Not Accepted](../docs/contributing/chatmodes.md#chatmodes-not-accepted) and [Model Version Requirements](../docs/contributing/ai-artifacts-common.md#model-version-requirements).
39+
> - See [Agents Not Accepted](../docs/contributing/custom-agents.md#agents-not-accepted) and [Model Version Requirements](../docs/contributing/ai-artifacts-common.md#model-version-requirements).
4040
4141
**Other:**
4242

@@ -49,7 +49,7 @@ Select all that apply:
4949
<!-- Delete this section if not applicable -->
5050

5151
**User Request:**
52-
<!-- What natural language request would trigger this chatmode/prompt/instruction? -->
52+
<!-- What natural language request would trigger this agent/prompt/instruction? -->
5353

5454
**Execution Flow:**
5555
<!-- Step-by-step: what happens when invoked? Include tool usage, decision points -->
@@ -63,7 +63,7 @@ Select all that apply:
6363
For detailed contribution requirements, see:
6464

6565
- **Common Standards**: [docs/contributing/ai-artifacts-common.md](../docs/contributing/ai-artifacts-common.md) - Shared standards for XML blocks, markdown quality, RFC 2119, validation, and testing
66-
- **Chatmodes**: [docs/contributing/chatmodes.md](../docs/contributing/chatmodes.md) - Agent configurations with tools and behavior patterns
66+
- **Agents**: [docs/contributing/custom-agents.md](../docs/contributing/custom-agents.md) - Agent configurations with tools and behavior patterns
6767
- **Prompts**: [docs/contributing/prompts.md](../docs/contributing/prompts.md) - Workflow-specific guidance with template variables
6868
- **Instructions**: [docs/contributing/instructions.md](../docs/contributing/instructions.md) - Technology-specific standards with glob patterns
6969

@@ -79,8 +79,8 @@ For detailed contribution requirements, see:
7979
- [ ] Changes are backwards compatible (if applicable)
8080

8181
### AI Artifact Contributions
82-
<!-- If contributing a chatmode, prompt, or instruction, complete these checks -->
83-
- [ ] Used `prompt-builder` chatmode to review contribution
82+
<!-- If contributing an agent, prompt, or instruction, complete these checks -->
83+
- [ ] Used `/prompt-analyze` to review contribution
8484
- [ ] Addressed all feedback from `prompt-builder` review
8585
- [ ] Verified contribution follows common standards and type-specific requirements
8686

0 commit comments

Comments
 (0)