Skip to content

Commit 57ef20d

Browse files
WilliamBerryiiiWilliamBerryiii
authored
fix(tools): correct Method 5 path resolution in hve-core-installer (#129)
# Pull Request ## Description Fixed a path resolution bug in the hve-core-installer agent where Method 5 (Multi-Root Workspace) used folder display names as path prefixes in VS Code settings. VS Code does not resolve display names in path settings, causing chatmodes, prompts, and instructions to fail to load. **Changes:** - Replaced folder display name prefixes with explicit relative paths in Method 5 workspace configuration - Changed `HVE-Core Library/.github/chatmodes` to `.github/chatmodes` and `../hve-core/.github/chatmodes` - Applied same pattern to `chat.promptFilesLocations` and `chat.instructionsFilesLocations` settings - Updated both PowerShell and Bash installation examples - Added comments explaining VS Code path resolution behavior - Added missing technical terms (`notmatch`, `popd`, `pushd`, `toplevel`) to cspell dictionary ## Related Issue(s) Fixes #128 ## Type of Change Select all that apply: **Code & Documentation:** - [x] Bug fix (non-breaking change fixing an issue) - [ ] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature causing existing functionality to change) - [x] Documentation update **Infrastructure & Configuration:** - [ ] GitHub Actions workflow - [ ] Linting configuration (markdown, PowerShell, etc.) - [ ] Security configuration - [ ] DevContainer configuration - [ ] Dependency update **AI Artifacts:** - [ ] Reviewed contribution with `prompt-builder` chatmode and addressed all feedback - [ ] Copilot instructions (`.github/instructions/*.instructions.md`) - [ ] Copilot prompt (`.github/prompts/*.prompt.md`) - [ ] Copilot chatmode (`.github/chatmodes/*.chatmode.md`) **Other:** - [ ] Script/automation (`.ps1`, `.sh`, `.py`) - [ ] Other (please describe): ## Testing - Verified markdown linting passes - Verified frontmatter validation passes - Verified spell check passes with added technical terms ## Checklist ### Required Checks - [x] Documentation is updated (if applicable) - [x] Files follow existing naming conventions - [x] Changes are backwards compatible (if applicable) ### Required Automated Checks The following validation commands must pass before merging: - [x] Markdown linting: `npm run lint:md` - [x] Spell checking: `npm run spell-check` - [x] Frontmatter validation: `npm run lint:frontmatter` - [ ] Link validation: `npm run lint:md-links` - [ ] PowerShell analysis: `npm run lint:ps` ## Security Considerations - [x] This PR does not contain any sensitive or NDA information - [x] Any new dependencies have been reviewed for security issues - [x] Security-related scripts follow the principle of least privilege ## Additional Notes 🐞 - Generated by Copilot
1 parent 160ae7a commit 57ef20d

2 files changed

Lines changed: 20 additions & 12 deletions

File tree

‎.cspell/general-technical.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1352,6 +1352,7 @@ keepbackup
13521352
checkpointed
13531353
parameterless
13541354
notnull
1355+
notmatch
13551356
gettype
13561357
lockfiles
13571358
workitem
@@ -1379,6 +1380,8 @@ typeparam
13791380
colcon
13801381
pathlib
13811382
popen
1383+
popd
1384+
pushd
13821385
expanduser
13831386
reqwest
13841387
pyyaml
@@ -1392,6 +1395,7 @@ cloudevents
13921395
datasize
13931396
mult
13941397
reqs
1398+
toplevel
13951399

13961400
# Video & Image Processing
13971401
drawtext

‎.github/agents/hve-core-installer.agent.md‎

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -617,6 +617,8 @@ if (Test-Path $mountedPath) {
617617
$ErrorActionPreference = 'Stop'
618618
619619
# Create multi-root workspace file
620+
# IMPORTANT: Do NOT use folder display names as path prefixes (e.g., "HVE-Core Library/.github").
621+
# VS Code does not resolve display names. Use actual relative paths from the workspace file location.
620622
$workspaceContent = @'
621623
{
622624
"folders": [
@@ -625,16 +627,16 @@ $workspaceContent = @'
625627
],
626628
"settings": {
627629
"chat.modeFilesLocations": {
628-
"HVE-Core Library/.github/chatmodes": true,
629-
"My Project/.github/chatmodes": true
630+
".github/chatmodes": true,
631+
"../hve-core/.github/chatmodes": true
630632
},
631633
"chat.promptFilesLocations": {
632-
"HVE-Core Library/.github/prompts": true,
633-
"My Project/.github/prompts": true
634+
".github/prompts": true,
635+
"../hve-core/.github/prompts": true
634636
},
635637
"chat.instructionsFilesLocations": {
636-
"HVE-Core Library/.github/instructions": true,
637-
"My Project/.github/instructions": true
638+
".github/instructions": true,
639+
"../hve-core/.github/instructions": true
638640
}
639641
},
640642
"extensions": {
@@ -652,6 +654,8 @@ Write-Host "✅ Created hve-core.code-workspace"
652654
#!/usr/bin/env bash
653655
set -euo pipefail
654656

657+
# IMPORTANT: Do NOT use folder display names as path prefixes (e.g., "HVE-Core Library/.github").
658+
# VS Code does not resolve display names. Use actual relative paths from the workspace file location.
655659
cat > hve-core.code-workspace << 'EOF'
656660
{
657661
"folders": [
@@ -660,16 +664,16 @@ cat > hve-core.code-workspace << 'EOF'
660664
],
661665
"settings": {
662666
"chat.modeFilesLocations": {
663-
"HVE-Core Library/.github/chatmodes": true,
664-
"My Project/.github/chatmodes": true
667+
".github/chatmodes": true,
668+
"../hve-core/.github/chatmodes": true
665669
},
666670
"chat.promptFilesLocations": {
667-
"HVE-Core Library/.github/prompts": true,
668-
"My Project/.github/prompts": true
671+
".github/prompts": true,
672+
"../hve-core/.github/prompts": true
669673
},
670674
"chat.instructionsFilesLocations": {
671-
"HVE-Core Library/.github/instructions": true,
672-
"My Project/.github/instructions": true
675+
".github/instructions": true,
676+
"../hve-core/.github/instructions": true
673677
}
674678
},
675679
"extensions": {

0 commit comments

Comments
 (0)