Skip to content

Commit 108e160

Browse files
CopilotkatriendgWilliamBerryiii
authored
feat: add Skills and VS Code Extension categories to issue/PR templates (#410)
## Implementation Plan - [x] Update bug-report.yml to add "Skills" and "VS Code Extension" to Component dropdown - [x] Create new skill-request.yml template following the pattern of existing request templates - [x] Update PULL_REQUEST_TEMPLATE.md to add Skills checkbox and reference link - [x] Remove single-platform options from skill-request.yml (only cross-platform allowed) - [x] Remove platform requirements section entirely (doesn't add value) - [x] Update AI artifact checklist to include "skill" in the comment - [x] Add PR template to frontmatter validation exclusion list to prevent CI failures - [x] Sync package.json frontmatter exclusions with workflow for consistent dev/CI experience - [x] Run validation (lint:yaml, lint:md, lint:frontmatter) to ensure templates pass all checks - [x] Verify all changes are correctly implemented <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[Issue]: add VS Code Extension and Skills categories to issue and PR templates</issue_title> > <issue_description>### Issue Description > > ## Background > > The repository recently added Skills as a new AI artifact type (`.github/skills/*/SKILL.md`) alongside agents, prompts, and instructions. The `video-to-gif` skill exists and is documented at `docs/contributing/skills.md`, but the issue templates and PR template do not recognize Skills as a contribution type. > > Additionally, the VS Code Extension (`extension/`) is a core deliverable but is missing from the bug report component list, preventing users from categorizing extension-specific bugs correctly. > > ## Current State > > | Template | Issue | > |----------|-------| > | `.github/ISSUE_TEMPLATE/bug-report.yml` | Missing "Skills" and "VS Code Extension" in Component dropdown | > | `.github/ISSUE_TEMPLATE/skill-request.yml` | Does not exist | > | `.github/PULL_REQUEST_TEMPLATE.md` | Missing Skills checkbox in AI Artifacts section | > > ## Work Required > > ### 1. Update Bug Report Template > > **File:** `.github/ISSUE_TEMPLATE/bug-report.yml` > > Add two new options to the Component dropdown: > > ```yaml > options: > - Instruction Files > - Prompts > - Custom Agents > - Skills # ADD > - VS Code Extension # ADD > - Scripts > - Documentation > - Other > ``` > > ### 2. Create Skill Request Issue Template > > **File:** `.github/ISSUE_TEMPLATE/skill-request.yml` (new file) > > Create template with: > > - **name:** `Skill Request` > - **description:** `Request a new skill package` > - **title:** `[Skill]: ` > - **labels:** `skill`, `needs-triage` > - **Fields:** > - Skill Name (input, required) > - Purpose (textarea, required) > - Platform Requirements (dropdown: Both bash and PowerShell, Bash only, PowerShell only) > - Prerequisites (textarea, optional) - external tools needed > - Requirements (textarea, optional) > > ### 3. Update PR Template > > **File:** `.github/PULL_REQUEST_TEMPLATE.md` > > Add Skills checkbox to AI Artifacts section: > > ```markdown > **AI Artifacts:** > > - [ ] Reviewed contribution with `prompt-builder` agent and addressed all feedback > - [ ] Copilot instructions (`.github/instructions/*.instructions.md`) > - [ ] Copilot prompt (`.github/prompts/*.prompt.md`) > - [ ] Copilot agent (`.github/agents/*.agent.md`) > - [ ] Copilot skill (`.github/skills/*/SKILL.md`) # ADD > ``` > > Add Skills reference to the note section: > > ```markdown > > - **Skills**: Must include both bash and PowerShell scripts. See [Skills](../docs/contributing/skills.md). > ``` > > ## Acceptance Criteria > > - [ ] Bug report template includes Skills and VS Code Extension options > - [ ] New `skill-request.yml` template exists and matches pattern of other request templates > - [ ] PR template includes Skills checkbox and reference link > - [ ] All templates pass `npm run lint:yaml` validation > > > ### Additional Context > > _No response_</issue_description> > > <agent_instructions>Start implementation, ensure you run the available validation tools like `npm run lint:md``, and `npm run lint:frontmatter` or other applicable ones to the types of files changed. Only finish and report back once validation passes.</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes #409 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/microsoft/hve-core/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: katriendg <[email protected]> Co-authored-by: Katrien De Graeve <[email protected]> Co-authored-by: Bill Berry <[email protected]>
1 parent 2ce6371 commit 108e160

5 files changed

Lines changed: 54 additions & 3 deletions

File tree

.github/ISSUE_TEMPLATE/bug-report.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ body:
1717
- Instruction Files
1818
- Prompts
1919
- Custom Agents
20+
- Skills
21+
- VS Code Extension
2022
- Scripts
2123
- Documentation
2224
- Other
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
name: Skill Request
2+
description: Request a new skill package
3+
title: "[Skill]: "
4+
labels: ["skill", "needs-triage"]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Request a new skill package for GitHub Copilot.
10+
11+
- type: input
12+
id: skill-name
13+
attributes:
14+
label: Skill Name
15+
description: What should this skill be named?
16+
placeholder: e.g., "docker-compose-gen"
17+
validations:
18+
required: true
19+
20+
- type: textarea
21+
id: purpose
22+
attributes:
23+
label: Purpose
24+
description: What problem does this skill solve?
25+
placeholder: Describe when and why this skill would be used
26+
validations:
27+
required: true
28+
29+
- type: textarea
30+
id: prerequisites
31+
attributes:
32+
label: Prerequisites
33+
description: What external tools or dependencies are needed?
34+
placeholder: List any required installations (e.g., ffmpeg, docker, jq)
35+
validations:
36+
required: false
37+
38+
- type: textarea
39+
id: requirements
40+
attributes:
41+
label: Requirements
42+
description: What specific behaviors should this skill enable?
43+
placeholder: List the key capabilities or features needed
44+
validations:
45+
required: false

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,12 @@ Select all that apply:
3131
- [ ] Copilot instructions (`.github/instructions/*.instructions.md`)
3232
- [ ] Copilot prompt (`.github/prompts/*.prompt.md`)
3333
- [ ] Copilot agent (`.github/agents/*.agent.md`)
34+
- [ ] Copilot skill (`.github/skills/*/SKILL.md`)
3435

3536
> **Note for AI Artifact Contributors**:
3637
>
3738
> - **Agents**: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review `.github/agents/` before creating new ones.
39+
> - **Skills**: Must include both bash and PowerShell scripts. See [Skills](../docs/contributing/skills.md).
3840
> - **Model Versions**: Only contributions targeting the **latest Anthropic and OpenAI models** will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
3941
> - See [Agents Not Accepted](../docs/contributing/custom-agents.md#agents-not-accepted) and [Model Version Requirements](../docs/contributing/ai-artifacts-common.md#model-version-requirements).
4042
@@ -66,6 +68,7 @@ For detailed contribution requirements, see:
6668
- **Agents**: [docs/contributing/custom-agents.md](../docs/contributing/custom-agents.md) - Agent configurations with tools and behavior patterns
6769
- **Prompts**: [docs/contributing/prompts.md](../docs/contributing/prompts.md) - Workflow-specific guidance with template variables
6870
- **Instructions**: [docs/contributing/instructions.md](../docs/contributing/instructions.md) - Technology-specific standards with glob patterns
71+
- **Skills**: [docs/contributing/skills.md](../docs/contributing/skills.md) - Task execution utilities with cross-platform scripts
6972

7073
## Testing
7174
<!-- Describe how you tested these changes -->
@@ -80,7 +83,7 @@ For detailed contribution requirements, see:
8083
- [ ] Tests added for new functionality (if applicable)
8184

8285
### AI Artifact Contributions
83-
<!-- If contributing an agent, prompt, or instruction, complete these checks -->
86+
<!-- If contributing an agent, prompt, instruction, or skill, complete these checks -->
8487
- [ ] Used `/prompt-analyze` to review contribution
8588
- [ ] Addressed all feedback from `prompt-builder` review
8689
- [ ] Verified contribution follows common standards and type-specific requirements

.github/workflows/frontmatter-validation.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ jobs:
7878
7979
# Exclude test fixture files (intentionally invalid frontmatter for testing)
8080
# and extension/README.md (uses VS Code marketplace format, not repo docs standards)
81-
$params['ExcludePaths'] = @('scripts/tests/Fixtures/**', 'extension/README.md')
81+
# and .github/PULL_REQUEST_TEMPLATE.md (GitHub template, not a documentation file)
82+
$params['ExcludePaths'] = @('scripts/tests/Fixtures/**', 'extension/README.md', '.github/PULL_REQUEST_TEMPLATE.md')
8283
8384
& scripts/linting/Validate-MarkdownFrontmatter.ps1 @params
8485
continue-on-error: true

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"lint:yaml": "pwsh -File scripts/linting/Invoke-YamlLint.ps1",
1414
"lint:links": "pwsh -NoProfile -Command \"& scripts/linting/Invoke-LinkLanguageCheck.ps1 -ExcludePaths 'scripts/tests/**'\"",
1515
"lint:md-links": "pwsh -File scripts/linting/Markdown-Link-Check.ps1",
16-
"lint:frontmatter": "pwsh -NoProfile -Command \"& scripts/linting/Validate-MarkdownFrontmatter.ps1 -WarningsAsErrors -EnableSchemaValidation -ExcludePaths 'scripts/tests/Fixtures/**'\"",
16+
"lint:frontmatter": "pwsh -NoProfile -Command \"& scripts/linting/Validate-MarkdownFrontmatter.ps1 -WarningsAsErrors -EnableSchemaValidation -ExcludePaths 'scripts/tests/Fixtures/**', 'extension/README.md', '.github/PULL_REQUEST_TEMPLATE.md'\"",
1717
"lint:all": "npm run format:tables && npm run lint:md && npm run lint:ps && npm run lint:yaml && npm run lint:links && npm run lint:frontmatter",
1818
"format:tables": "markdown-table-formatter \"**/*.md\"",
1919
"extension:prepare": "pwsh ./scripts/extension/Prepare-Extension.ps1",

0 commit comments

Comments
 (0)