add logic to stack lcow layers on a single VPMEM device #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
force-pushed
the
user/maksiman/device-mapper
branch
4 times, most recently
from
f3ddb24 to
5459050
Compare
anmaxvl
force-pushed
the
user/maksiman/device-mapper
branch
5 times, most recently
from
9c8e6fe to
3c00b47
Compare
anmaxvl
force-pushed
the
user/maksiman/device-mapper
branch
3 times, most recently
from
710fdcb to
bca9a89
Compare
anmaxvl
force-pushed
the
user/maksiman/device-mapper
branch
from
bca9a89 to
a98df30
Compare
|
It might be good if you could make an issue on hcsshim for this and describe the memory allocation method and any other additional big changes proposed here. |
dcantah
reviewed
Feb 5, 2021
dcantah
reviewed
Feb 5, 2021
dcantah
reviewed
Feb 5, 2021
dcantah
reviewed
Feb 5, 2021
anmaxvl
force-pushed
the
user/maksiman/device-mapper
branch
from
727b0ac to
a5cb324
Compare
katiewasnothere
approved these changes
Jun 1, 2021
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
couple of non blocking nits, otherwise LGTM
anmaxvl
force-pushed
the
user/maksiman/device-mapper
branch
6 times, most recently
from
4f78a97 to
f29620b
Compare
katiewasnothere
approved these changes
Jun 3, 2021
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
Thanks for the fixes, LGTM again :)
anmaxvl
force-pushed
the
user/maksiman/device-mapper
branch
from
f29620b to
59a90b5
Compare
add VirtualPMemMapping schema and update gcs types add memory allocator interface and implementation VPMem multi-mapping support has been added in 19H1, which enables packing multiple VHDs onto a single VPMem device. This feature enables an optimization, where multiple LCOW container layers can be packed onto a single VPMem device. This change uses memory allocator introduced above to keep track of the VPMem surface allocation. Additionally, introduce new structs to keep track of the internal state of each mapped LCOW layer VHD and update HCS/GCS calls accordingly. The optimization is enabled by default on supported systems and fall-back to old behavior otherwise. add CRI tests Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
user/maksiman/device-mapper
branch
from
59a90b5 to
9ed9300
Compare
Contributor
|
The force push was fixing some edgecases I think you said this morning? |
Contributor
Author
yeah, I added one more test case to cover rootfs.vhd vs initrd (it was defaulting to only do rootfs) |
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Jul 14, 2021
This was left behind due to an unlucky conflict between microsoft#1004 and microsoft#930. The file already existed with the same content at the new location, and nothing was referencing this location, so a trivial deletion. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…pper add logic to stack lcow layers on a single VPMEM device
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
This was left behind due to an unlucky conflict between microsoft#1004 and microsoft#930. The file already existed with the same content at the new location, and nothing was referencing this location, so a trivial deletion. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to reuse an existing VPMEM device and stack multiple LCOW layers onto it.
The change depends on microsoft/opengcs#389
More background in #940
Signed-off-by: Maksim An [email protected]