Add better handling of windows-style paths for io_binary #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
force-pushed
the
user/maksiman/binary-io-better-path-handling
branch
from
86573c4 to
03e0c1f
Compare
internal/cmd/io_binary.go
Outdated
| } | ||
|
|
||
| // Strip any leading '\\' if the path contains a hard drive in it. | ||
| if strings.Contains(sanitized, ":\\") { |
There was a problem hiding this comment.
I'm confused about this section. Could :\\ be anywhere in the path?
Contributor
Author
There was a problem hiding this comment.
like if we have multiple volumes, e.g. C:\path\to\something and D:\path\to\something. or am I missing something?
internal/cmd/io_binary.go
Outdated
Comment on lines
133
to
124
| if uri.Host != "" { | ||
| return "\\" + uri.Host + sanitized | ||
| } |
There was a problem hiding this comment.
Is it possible that uri.Host could already have a leading \\ like in the hard drive case above?
Contributor
Author
There was a problem hiding this comment.
url.Parse will complain about back slashes in hostname, so things should fail before we even get here.
anmaxvl
force-pushed
the
user/maksiman/binary-io-better-path-handling
branch
from
03e0c1f to
54adb4d
Compare
kevpar
reviewed
Jan 27, 2021
kevpar
reviewed
Jan 27, 2021
kevpar
reviewed
Jan 27, 2021
kevpar
reviewed
Jan 27, 2021
anmaxvl
force-pushed
the
user/maksiman/binary-io-better-path-handling
branch
2 times, most recently
from
8e5e6b5 to
f2e1d8c
Compare
kevpar
reviewed
Jan 28, 2021
anmaxvl
force-pushed
the
user/maksiman/binary-io-better-path-handling
branch
from
f2e1d8c to
91416a5
Compare
Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
user/maksiman/binary-io-better-path-handling
branch
from
91416a5 to
bbae6da
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Maksim An <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a better job at cleaning the logging driver path.
Add support for non-default hard drives.