Skip to content

Conversation

@elweb9858
Copy link
Contributor

This PR reflects the HNS L4WfpProxyPolicy change to allow the caller to distinguish the inbound and outbound proxy ports

@dcantah
Copy link
Contributor

dcantah commented Dec 15, 2020

@elweb9858 CI's just whining about gofmt on a file so should be an easy fix, but could you sign off on this commit with git commit --amend -s? Another question, when did this change? Didn't we just cut a new release so that this could be vendored somewhere?

@dcantah
Copy link
Contributor

dcantah commented Dec 15, 2020

Err, it was this PR that David stated we needed actually: #890

@elweb9858
Copy link
Contributor Author

@dcantah yeah the naming similarity of l4proxy and l4wfpproxy is unfortunate. but yes, I will fix the formatting and sign the commit

Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, LGTM then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants