Add support for issuing a container update to gcs #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiewasnothere
force-pushed
the
gcs_update_container
branch
from
54fc9d3 to
570af7f
Compare
anmaxvl
approved these changes
Dec 10, 2020
Contributor
anmaxvl
left a comment
anmaxvl
left a comment
There was a problem hiding this comment.
lgtm. just one small question
internal/gcs/container.go
Outdated
| // UpdateContainerMemory makes a modify request on the given cow container to modify the memory size | ||
| // Internally, this will modify the container's job object memory limits | ||
| func UpdateContainerMemory(ctx context.Context, c cow.Container, newMemorySizeInBytes uint64) error { | ||
| newMemorySizeInMB := newMemorySizeInBytes / bytesPerMB |
Contributor
There was a problem hiding this comment.
should we allow this to be 0 or default to some minimum (e.g. 2MB)?
Author
There was a problem hiding this comment.
That's a good question. I'm not sure what would happen if the memory size requested was 0. I can test and find out though.
dcantah
reviewed
Dec 16, 2020
| } | ||
|
|
||
| func (gc *GuestConnection) UpdateContainer(ctx context.Context, cid string, resources interface{}) (err error) { | ||
| ctx, span := trace.StartSpan(ctx, "gcs::GuestConnection::UpdateContainer") |
Contributor
There was a problem hiding this comment.
I think for new code the plan was to stop with the :: convention in our logs and use periods but my mind is hazy.
Author
There was a problem hiding this comment.
@kevpar can you comment on this? I wanted to be consistent with the other guest connection traces
dcantah
reviewed
Dec 17, 2020
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
gcs_update_container
branch
from
570af7f to
6e87c0c
Compare
dcantah
approved these changes
Dec 22, 2020
anmaxvl
approved these changes
Dec 22, 2020
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…ainer Add support for issuing a container update to gcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the ongoing dynamic resources work. This PR adds new calls to allow hcsshim to issue container update requests to the running GCS.
Signed-off-by: Kathryn Baldauf [email protected]