add test for running container as non-default user that is missing #904
Conversation
| Config: &runtime.PodSandboxConfig{ | ||
| Metadata: &runtime.PodSandboxMetadata{ | ||
| Name: t.Name(), | ||
| Uid: "0", |
There was a problem hiding this comment.
No idea what this is used for 🤣 but we aren't setting it anymore for a couple tests.
There was a problem hiding this comment.
from what I saw, it's used to construct sandbox name. so having it set to the same value doesn't accomplish much... we could randomize it I guess.
|
Maybe two separate commits would help here for better git history. First commit -> refactor and second commit -> add new test. |
anmaxvl
force-pushed
the
tests/run-lcow-non-default-user
branch
from
9a2bc9e to
bd2844c
Compare
Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
tests/run-lcow-non-default-user
branch
from
bd2844c to
dca168e
Compare
|
Thanks for adding this test! |
yeah, sure. |
Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
tests/run-lcow-non-default-user
branch
from
dca168e to
c4f4fbe
Compare
and done |
|
LGTM! |
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
3 participants
refector tests to use getRunPodSandboxRequest where possible
Signed-off-by: Maksim An [email protected]