Force disable VSMB direct map when the volume does not support it #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSMB direct map requires support for querying FileIdInfo from the backing volume. There is a bug in certain Windows versions where instead of falling back to non-direct map when FileIdInfo is not supported, VSMB instead causes errors whenever files on the share are accessed. To work around this until the issue is fixed, we will query FileIdInfo ourselves when setting up a VSMB share, and force disable direct map if the query fails. Signed-off-by: Kevin Parsons <[email protected]>
dcantah
reviewed
Nov 11, 2020
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSMB direct map requires support for querying FileIdInfo from the
backing volume. There is a bug in certain Windows versions where instead
of falling back to non-direct map when FileIdInfo is not supported, VSMB
instead causes errors whenever files on the share are accessed.
To work around this until the issue is fixed, we will query FileIdInfo
ourselves when setting up a VSMB share, and force disable direct map if
the query fails.
Signed-off-by: Kevin Parsons [email protected]