Support assigning cpugroup immediately after UVM start #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiewasnothere
force-pushed
the
cpugroup_vm_create_on_start
branch
from
6aba54d to
6b8bb2f
Compare
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
dcantah
reviewed
Oct 27, 2020
dcantah
reviewed
Oct 27, 2020
dcantah
reviewed
Oct 27, 2020
dcantah
reviewed
Oct 27, 2020
katiewasnothere
force-pushed
the
cpugroup_vm_create_on_start
branch
from
6b8bb2f to
2678abe
Compare
kevpar
reviewed
Oct 27, 2020
kevpar
reviewed
Oct 27, 2020
katiewasnothere
force-pushed
the
cpugroup_vm_create_on_start
branch
from
2678abe to
a9cf4d1
Compare
dcantah
reviewed
Oct 27, 2020
katiewasnothere
force-pushed
the
cpugroup_vm_create_on_start
branch
2 times, most recently
from
3294bc7 to
47845df
Compare
kevpar
reviewed
Oct 28, 2020
| @@ -0,0 +1,121 @@ | |||
| package uvm | |||
Member
There was a problem hiding this comment.
I think we should move out the core CPU groups support into an internal/cpugroup package, and just call into that from uvm.SetCPUGroup and uvm.UnsetCPUGroup.
Author
There was a problem hiding this comment.
There are some standalone pieces that I moved out, but the code that needs to be run in Set/Unset/Release require the uvm package, so I did not move those. Let me know if it looks okay.
kevpar
reviewed
Oct 28, 2020
katiewasnothere
force-pushed
the
cpugroup_vm_create_on_start
branch
from
47845df to
8e78880
Compare
dcantah
reviewed
Nov 17, 2020
dcantah
reviewed
Nov 17, 2020
dcantah
reviewed
Nov 17, 2020
dcantah
reviewed
Nov 18, 2020
dcantah
reviewed
Nov 18, 2020
dcantah
reviewed
Nov 18, 2020
katiewasnothere
force-pushed
the
cpugroup_vm_create_on_start
branch
2 times, most recently
from
b8689b3 to
b08f737
Compare
dcantah
reviewed
Nov 19, 2020
internal/cpugroup/cpugroup.go
Outdated
| LogicalProcessorCount: uint32(len(logicalProcessors)), | ||
| } | ||
| if err := modifyCPUGroupRequest(ctx, operation, details); err != nil { | ||
| return fmt.Errorf("failed to make cpugroups CreateGroup request with details %v with: %s", details, err) |
Contributor
There was a problem hiding this comment.
nit: Can we just make this
return errors.Wrapf(err, "failed to create CPU group with details %v")the "with details x with y" is odd to read
| ) | ||
|
|
||
| // hostProcessorInfo queries HCS for the UVM hosts processor information, including topology | ||
| // HostProcessorInfo queries HCS for the UVM hosts processor information, including topology |
Contributor
There was a problem hiding this comment.
Can omit the part of the comment that mentions this is for the UVMs host as this is in a more general package now.
dcantah
approved these changes
Nov 19, 2020
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
LGTM. 2 nitpicky comments
anmaxvl
reviewed
Dec 9, 2020
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
cpugroup_vm_create_on_start
branch
from
b08f737 to
bac6480
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…ate_on_start Support assigning cpugroup immediately after UVM start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new annotation
io.microsoft.virtualmachine.cpugroup.idfor pod configuration that allows for specifying the ID of a cpugroup the corresponding UVM should be added to. This PR also adds e2e tests and a unit test, which is disabled since cpugroups is only enabled on systems with classic/core scheduling type.Signed-off-by: Kathryn Baldauf [email protected]