Add tests for removing sandbox pod, without stopping it #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
force-pushed
the
tests-for-pod-removal-without-pod-stop
branch
from
1290b69 to
a9adba7
Compare
anmaxvl
force-pushed
the
tests-for-pod-removal-without-pod-stop
branch
from
a9adba7 to
1bcdceb
Compare
anmaxvl
force-pushed
the
tests-for-pod-removal-without-pod-stop
branch
from
1bcdceb to
6cf51a5
Compare
anmaxvl
force-pushed
the
tests-for-pod-removal-without-pod-stop
branch
from
6cf51a5 to
d2de9d1
Compare
dcantah
reviewed
Nov 3, 2020
| } | ||
|
|
||
| func getRunPodSandboxRequest(t *testing.T, runtimeHandler string) runtime.RunPodSandboxRequest { | ||
| return runtime.RunPodSandboxRequest{ |
Contributor
There was a problem hiding this comment.
I like this, might be useful to replace all of the easy (e.g. nothing other than the runtime handler needing to be filled out) RunPodSandboxRequests we have in our tests with this also. Doesn't need to be this PR though :P
Contributor
Author
There was a problem hiding this comment.
I'll file a separate PR for this 😄
dcantah
reviewed
Nov 3, 2020
dcantah
approved these changes
Nov 3, 2020
Contributor
|
LGTM. Minor nitpicks on variables |
Contributor
|
@anmaxvl We can check this in whenever, you can do the honors :) |
Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
tests-for-pod-removal-without-pod-stop
branch
from
d2de9d1 to
5acb8e6
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.