Add tests for late cloning #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambarve
changed the title
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
f3c05e0 to
0602db5
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
2ac7199 to
3464574
Compare
dcantah
reviewed
Jun 16, 2020
dcantah
reviewed
Jun 16, 2020
dcantah
reviewed
Jun 16, 2020
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
b2ecf9d to
3da5e98
Compare
ambarve
changed the title
Member
|
Please rebase these commits into a more curated set for review and check-in. |
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
3f1bc7a to
c7e0f63
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
b61ae9f to
358eac5
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
c7e0f63 to
7a15559
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
2 times, most recently
from
8ca774f to
857d169
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
7a15559 to
014132d
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
857d169 to
3bd25c9
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
014132d to
6dabd0d
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
6dabd0d to
a7848c5
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
41cd572 to
e641b3c
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
a7848c5 to
b741e39
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
2 times, most recently
from
7bfb715 to
5de69a5
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
2 times, most recently
from
8625f9a to
a0596a7
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
5de69a5 to
82fb4d3
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
82fb4d3 to
020e6a4
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
a0596a7 to
ff2fbe3
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
020e6a4 to
6cf9c65
Compare
dcantah
reviewed
Nov 17, 2020
| _, err := client.RunPodSandbox(ctx, cloneSandboxRequest) | ||
| if err == nil { | ||
| t.Fatalf("pod cloning should fail with mismatching configurations error") | ||
| } else if !strings.Contains(err.Error(), "doesn't match") { |
Contributor
There was a problem hiding this comment.
Anyway (it's obviously not present in this PR) that we could export the err value so we could use it directly here. If we ever changed the error string this would break
dcantah
approved these changes
Nov 17, 2020
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
LGTM. One suggestion that's more for another PR really
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
ff2fbe3 to
3fe9813
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
6cf9c65 to
5b85a7a
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
3fe9813 to
2379dd1
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
5b85a7a to
519979f
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
from
2379dd1 to
65faf47
Compare
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
519979f to
a6ad0f9
Compare
ambarve
force-pushed
the
user/ambarve/lcpr4_clone_contianer
branch
2 times, most recently
from
9de34df to
452b379
Compare
This is one of the many small PRs that enable the support for late cloning. This commit adds several end to end tests for the late cloning feature. Signed-off-by: Amit Barve <[email protected]>
ambarve
force-pushed
the
user/ambarve/lcpr5_clone_tests
branch
from
a6ad0f9 to
e7f1f8a
Compare
Contributor
|
@ambarve, is there anything needed for this? Or you were looking for Kathryns sign off also as she was reviewing? |
Contributor
Author
|
Oh, I didn't realize that Kathryn had marked the conversation as resolved. I was just waiting to see if she had something more to say about it. But I will merge this now. Cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the many small PRs that enable the support for late cloning.
This commit adds several end to end tests for the late cloning feature.
Signed-off-by: Amit Barve [email protected]