Check whether we are already attached/detached before hot attach/deta…#573
Merged
jterry75 merged 1 commit intomicrosoft:masterfrom May 1, 2019
Merged
Conversation
Contributor
Author
madhanrm
reviewed
Apr 22, 2019
internal/hns/hnsendpoint.go
Outdated
| return true, err | ||
| } | ||
|
|
||
| if strings.Contains(string(attachInfo.SharedContainers), vID) || |
Contributor
There was a problem hiding this comment.
SharedContainers should be sufficient for v1 Argon
There is no shared containers for v1 Xenon
Why are you checking VirtualMachine ?
Contributor
Author
There was a problem hiding this comment.
For completeness I guess, I can remove if you want.
Contributor
Author
There was a problem hiding this comment.
@madhanrm fixed, take a look, I want to revendor the plugins repo w/ this.
Contributor
Author
There was a problem hiding this comment.
ugh, actually we should probably put them both to lower.
nagiesek
force-pushed
the
ignoreDuplicateHotAttachDetach
branch
2 times, most recently
from
373d779 to
b272896
Compare
Contributor
|
/LGTM |
Contributor
Author
jterry75
reviewed
May 1, 2019
jterry75
reviewed
May 1, 2019
nagiesek
force-pushed
the
ignoreDuplicateHotAttachDetach
branch
from
b272896 to
6d67a30
Compare
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…chDetach Check whether we are already attached/detached before hot attach/deta…
This was referenced Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ch calls