Skip to content

Setup stackdump correctly; add debugger event#480

Merged
lowenna merged 1 commit intomasterfrom
jjh/debug
Feb 16, 2019
Merged

Setup stackdump correctly; add debugger event#480
lowenna merged 1 commit intomasterfrom
jjh/debug

Conversation

@lowenna
Copy link
Copy Markdown
Contributor

@lowenna lowenna commented Feb 15, 2019

Signed-off-by: John Howard [email protected]

Doing a blanket update of the event name for consistency across docker, containerd, containerd-shim-runhcs-v1 and docker-signal to make life a lot easier and less typing.

  • We weren't previously ever setting up the dump stack event 😲
  • Adds a debugger wait event triggered during create

(moby/moby#38741 for the related moby change.)

@jterry75 PTAL

@lowenna lowenna requested a review from jterry75 February 15, 2019 23:32
@lowenna lowenna changed the title Setup stackdump correct; debug event Setup stackdump correctly; add debugger event Feb 15, 2019
Comment thread cmd/containerd-shim-runhcs-v1/service_internal.go Outdated
@jterry75
Copy link
Copy Markdown
Contributor

LGTM

@lowenna lowenna merged commit 66947b2 into master Feb 16, 2019
@lowenna lowenna deleted the jjh/debug branch February 16, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants