Expose DSR Settings in Load Balancer #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI @erfrimod |
jterry75
reviewed
Oct 18, 2018
hcn/hcnendpoint_test.go
Outdated
| } | ||
| if foundEndpoint == nil { | ||
| t.Errorf("No Endpoint found") | ||
| t.Fatalf("No Endpoint found") |
jterry75
reviewed
Oct 18, 2018
hcn/hcnendpoint_test.go
Outdated
| } | ||
| if foundEndpoint == nil { | ||
| t.Errorf("No Endpoint found") | ||
| t.Fatalf("No Endpoint found") |
jterry75
reviewed
Oct 18, 2018
hcn/hcnendpoint_test.go
Outdated
| } | ||
| if len(foundEndpoints) == 0 { | ||
| t.Errorf("No Endpoint found") | ||
| t.Fatalf("No Endpoint found") |
jterry75
reviewed
Oct 18, 2018
hcn/hcnendpoint_test.go
Outdated
| } | ||
| if len(foundEndpoints) == 0 { | ||
| t.Errorf("No Endpoint found") | ||
| t.Fatalf("No Endpoint found") |
jterry75
reviewed
Oct 18, 2018
hcn/hcnendpoint_test.go
Outdated
| } | ||
| if Endpoint.HostComputeNamespace == "" { | ||
| t.Errorf("No Namespace detected.") | ||
| t.Fatalf("No Namespace detected.") |
jterry75
reviewed
Oct 18, 2018
hcn/hcnendpoint_test.go
Outdated
| } | ||
| if len(foundEndpoint.Policies) == 0 { | ||
| t.Errorf("No Endpoint Policies found") | ||
| t.Fatalf("No Endpoint Policies found") |
jterry75
reviewed
Oct 18, 2018
hcn/hcnendpoint_test.go
Outdated
| } | ||
| if len(foundEndpoint.Policies) == 0 { | ||
| t.Errorf("No Endpoint Policies found") | ||
| t.Fatalf("No Endpoint Policies found") |
jterry75
reviewed
Oct 18, 2018
hcn/hcnerrors_test.go
Outdated
| _, err := GetNetworkByName("Not found name") | ||
| if err == nil { | ||
| t.Errorf("Error was not thrown.") | ||
| t.Fatalf("Error was not thrown.") |
Expose ELB DSR flag
Contributor
Author
|
@jterry75 can you get this merged? |
Contributor
|
@madhanrm - Done |
Contributor
Author
|
@jterry75 Thanks! |
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
Fix issue causing SCSI hot add to find no matching device
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 28, 2024
Expose DSR Settings in Load Balancer
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Expose DSR Settings in Load Balancer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose DSR Settings in Load Balancer
Fix Hcn tests to continue on failure.