Adding Namespace to HNS exports.#311
Merged
jterry75 merged 1 commit intomicrosoft:masterfrom Sep 20, 2018
Merged
Conversation
… Namespace in HNS V1.
jterry75
reviewed
Sep 18, 2018
| // HNSEndpoint represents a network endpoint in HNS | ||
| type HNSEndpoint = hns.HNSEndpoint | ||
| // Namespace represents a Compartment. | ||
| type Namespace = hns.Namespace |
Contributor
There was a problem hiding this comment.
What uses this? I dont quite understand why this export is needed for any V1 code?
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
Ignore ResizeConsole of init process after exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CNI needs to use the V1 Schema until customers can get the updated HNS code in RS6. This means that the Hcsshim needs to export the Namespace object that is a part of HNSEndpoint.