Skip to content

Changes for checking the global version for modify policy version support.#2139

Merged
helsaawy merged 1 commit intomicrosoft:mainfrom
princepereira:user/ppereira/modifyPolicyVersion
Jun 4, 2024
Merged

Changes for checking the global version for modify policy version support.#2139
helsaawy merged 1 commit intomicrosoft:mainfrom
princepereira:user/ppereira/modifyPolicyVersion

Conversation

@princepereira
Copy link
Copy Markdown
Contributor

@princepereira princepereira commented May 10, 2024

This to check the if the current version of hns supports modify loadbalancer. These functions will be used by Kube proxy to decide whether to go with modify loadbalancer api or not.

@princepereira princepereira requested a review from a team as a code owner May 10, 2024 03:14
Comment thread hcn/hcnerrors.go Outdated
Comment thread hcn/hcnglobals.go Outdated
@princepereira princepereira force-pushed the user/ppereira/modifyPolicyVersion branch 2 times, most recently from 8a23046 to 29907e1 Compare May 13, 2024 07:10
@msscotb msscotb assigned anmaxvl and helsaawy and unassigned anmaxvl and helsaawy May 17, 2024
@princepereira princepereira force-pushed the user/ppereira/modifyPolicyVersion branch from 29907e1 to 555a8e1 Compare May 18, 2024 11:05
Comment thread hcn/hcnpolicy.go Outdated
@helsaawy helsaawy self-assigned this May 22, 2024
@msscotb msscotb assigned helsaawy and unassigned helsaawy May 22, 2024
@princepereira princepereira force-pushed the user/ppereira/modifyPolicyVersion branch from 555a8e1 to e609f69 Compare May 27, 2024 05:31
@princepereira princepereira force-pushed the user/ppereira/modifyPolicyVersion branch from e609f69 to 0daa926 Compare May 30, 2024 10:11
@sbangari
Copy link
Copy Markdown

sbangari commented Jun 4, 2024

/approve

@helsaawy helsaawy merged commit 8beabac into microsoft:main Jun 4, 2024
kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Jun 6, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <[email protected]>
(cherry picked from commit 8beabac)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok pushed a commit that referenced this pull request Jun 7, 2024
…port. (#2139)

Signed-off-by: Prince Pereira <[email protected]>
(cherry picked from commit 8beabac)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Jun 13, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <[email protected]>
(cherry picked from commit 8beabac)
Signed-off-by: Kirtana Ashok <[email protected]>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 19, 2024
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 19, 2024
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 19, 2024
kiashok pushed a commit that referenced this pull request Jun 19, 2024
kiashok pushed a commit that referenced this pull request Jun 19, 2024
kiashok pushed a commit that referenced this pull request Jun 19, 2024
princepereira added a commit to princepereira/hcsshim that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants