Add hvsock service config annotation#2056
Merged
helsaawy merged 1 commit intomicrosoft:mainfrom Mar 18, 2024
Merged
Conversation
helsaawy
force-pushed
the
hvsock-service-config
branch
from
003eef5 to
da6f068
Compare
katiewasnothere
approved these changes
Mar 15, 2024
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
Couple questions but otherwise lgtm
Allow specifying the hyper-v configuration for specific service GUIDs via an annotation to allow dedicated hvsocket communication from the host to the guest Signed-off-by: Hamza El-Saawy <[email protected]>
helsaawy
force-pushed
the
hvsock-service-config
branch
from
da6f068 to
3c60472
Compare
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Allow specifying the hyper-v configuration for specific service GUIDs via an annotation to allow dedicated hvsocket communication from the host to the guest Signed-off-by: Hamza El-Saawy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow specifying the hyper-v configuration for specific service GUIDs via an annotation to allow dedicated hvsocket communication from the host to the guest