[test] Update manifest; go generate#1919
Merged
helsaawy merged 1 commit intomicrosoft:mainfrom Dec 6, 2023
Merged
Conversation
yyatmsft
reviewed
Oct 24, 2023
Contributor
yyatmsft
left a comment
yyatmsft
left a comment
There was a problem hiding this comment.
Can you state in the description that the purpose for the change is to validate that the syso files being checked in are up to date?
yyatmsft
approved these changes
Oct 24, 2023
helsaawy
force-pushed
the
mainfest-desc
branch
from
9a456c7 to
fe81a0c
Compare
Update description in manifest used for `test/` binaries. Add `test/tools.go` (similar to `tools/tools.go`), to track `goversioninfo` command. Update `.github/workflows/ci.yml` to run `go generate` from within `test/`. Signed-off-by: Hamza El-Saawy <[email protected]>
helsaawy
force-pushed
the
mainfest-desc
branch
from
fe81a0c to
f367ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update description in manifest used for
test/binaries.Add
test/tools.go(similar totools/tools.go), to trackgoversioninfocommand.Update
.github/workflows/ci.ymlto rungo generatefrom withintest/to validate that generated files (ie, syso files intest/pkg/manifest) are up to date (similar to what is done for the root module)