use protojson when formatting for logs#1844
Merged
helsaawy merged 1 commit intomicrosoft:mainfrom Jul 20, 2023
Merged
Conversation
Signed-off-by: Hamza El-Saawy <[email protected]>
Contributor
|
nit: It would be good to have an example of how proto message encoding looks without this change vs how it will look after this change in the PR description. |
ambarve
approved these changes
Jul 20, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Hamza El-Saawy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use
google.golang.org/protobuf/encoding/protojsonwhen encoding protobuf structs in logs.the biggest difference will be enums being encoded by their string name instead of numerical value