Skip to content

Replace deprecated github.com/golang/mock#1839

Merged
helsaawy merged 1 commit intomicrosoft:mainfrom
helsaawy:gomock
Jul 11, 2023
Merged

Replace deprecated github.com/golang/mock#1839
helsaawy merged 1 commit intomicrosoft:mainfrom
helsaawy:gomock

Conversation

@helsaawy
Copy link
Copy Markdown
Contributor

https://github.com/golang/mock is deprecated, and the repo is archived.
Recommended replacement is go.uber.org/mock

@helsaawy helsaawy requested a review from a team as a code owner July 11, 2023 21:24
Copy link
Copy Markdown

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sad that go has decided to no longer support this officially, I wonder what their reasons were :/

@helsaawy helsaawy merged commit 619018c into microsoft:main Jul 11, 2023
@helsaawy helsaawy deleted the gomock branch July 11, 2023 22:23
kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Aug 16, 2023
Signed-off-by: Hamza El-Saawy <[email protected]>
(cherry picked from commit 619018c)
Signed-off-by: Kirtana Ashok <[email protected]>

s

Signed-off-by: Kirtana Ashok <[email protected]>
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants