Skip to content

Add support for platform compatibility check for windows#1821

Merged
kiashok merged 1 commit intomicrosoft:mainfrom
kiashok:stableABICheck
Jul 5, 2023
Merged

Add support for platform compatibility check for windows#1821
kiashok merged 1 commit intomicrosoft:mainfrom
kiashok:stableABICheck

Conversation

@kiashok
Copy link
Contributor

@kiashok kiashok commented Jun 21, 2023 •
edited
Loading

This PR adds does the following:

  • Adds function to check the host OS version and container image's OS version and returns true if the two OS versions are compatible.
  • Add stable ABI compat version checks. OS releases > WS2022 will be stable ABI compliant and the decision is to support latest container images for stable ABI compliant OSes. (Stable ABI is in preview mode on windows 11)

@kiashok kiashok requested a review from a team as a code owner June 21, 2023 00:37
jsturtevant
jsturtevant reviewed Jun 21, 2023
View reviewed changes
@kiashok kiashok force-pushed the stableABICheck branch 3 times, most recently from 5bb3091 to 9a54249 Compare June 21, 2023 22:49
jsturtevant
jsturtevant reviewed Jun 21, 2023
View reviewed changes
kevpar
kevpar reviewed Jun 23, 2023
View reviewed changes
kevpar
kevpar reviewed Jun 23, 2023
View reviewed changes
kevpar
kevpar reviewed Jun 23, 2023
View reviewed changes
kevpar
kevpar reviewed Jun 23, 2023
View reviewed changes
kevpar
kevpar reviewed Jun 23, 2023
View reviewed changes
kevpar
kevpar reviewed Jun 23, 2023
View reviewed changes
jterry75
jterry75 reviewed Jun 26, 2023
View reviewed changes
jterry75
jterry75 reviewed Jun 26, 2023
View reviewed changes
kevpar
kevpar reviewed Jun 27, 2023
View reviewed changes
kevpar
kevpar reviewed Jun 27, 2023
View reviewed changes
@kiashok kiashok force-pushed the stableABICheck branch 2 times, most recently from 162f281 to 5008c39 Compare June 27, 2023 19:39
kevpar
kevpar approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75
Copy link
Contributor

jterry75 commented Jul 3, 2023

Ok last comment lolz. AreHostAndGuest is why this sounds like virtualization API IMO. The process container is not a Guest in my head. But I'm not 100% sure what to call it that is a short name. Its really more like CanHostRunUserSpaceVersion(hostVer, containerVer). Maybe you can think of a better name but otherwise LGTM

@kiashok
Copy link
Contributor Author

kiashok commented Jul 3, 2023

Ok last comment lolz. AreHostAndGuest is why this sounds like virtualization API IMO. The process container is not a Guest in my head. But I'm not 100% sure what to call it that is a short name. Its really more like CanHostRunUserSpaceVersion(hostVer, containerVer). Maybe you can think of a better name but otherwise LGTM

Does CheckHostAndContainerCompat() sound ok to you?

@jterry75
Copy link
Contributor

jterry75 commented Jul 3, 2023

Ack sounds great!

@kiashok
Copy link
Contributor Author

kiashok commented Jul 3, 2023

Ack sounds great!

@jterry75 pushed new changes. Could you please sign off if it looks good?

katiewasnothere
katiewasnothere reviewed Jul 3, 2023
View reviewed changes
katiewasnothere
katiewasnothere approved these changes Jul 5, 2023
View reviewed changes
Copy link

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiashok kiashok merged commit 640a560 into microsoft:main Jul 5, 2023
@kiashok kiashok mentioned this pull request Jul 5, 2023
Merged
kiashok added a commit to kiashok/hcsshim that referenced this pull request Jul 20, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
5f66cfb 
)

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok added a commit to kiashok/hcsshim that referenced this pull request Jul 20, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
47a111a 
)

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok added a commit to kiashok/hcsshim that referenced this pull request Jul 20, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
4bcd148 
)

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok added a commit that referenced this pull request Jul 20, 2023
@kiashok
[release/0.9] Add support for platform compatibility check for window…
9cd2a01 
…s + add windows builds (#1843)

* Add windows versions to windows builds

Signed-off-by: Kirtana Ashok <[email protected]>

* Add support for platform compatibility check for windows (#1821)

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <[email protected]>

---------

Signed-off-by: Kirtana Ashok <[email protected]>
@kiashok kiashok mentioned this pull request Aug 1, 2023
Closed
kiashok added a commit to kiashok/hcsshim that referenced this pull request Aug 29, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
cc4f8c5 
)

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok added a commit to kiashok/hcsshim that referenced this pull request Aug 31, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
ba0d4c1 
)

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok added a commit to kiashok/hcsshim that referenced this pull request Sep 1, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
90c0726 
)

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok added a commit to kiashok/hcsshim that referenced this pull request Sep 1, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
439e2dd 
)

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <[email protected]>
kiashok added a commit that referenced this pull request Sep 6, 2023
@kiashok
Add support for platform compatibility check for windows (#1821) (#1878)
750e11b 
(cherry picked from commit 640a560)

Signed-off-by: Kirtana Ashok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jterry75 jterry75 jterry75 left review comments

@kevpar kevpar kevpar approved these changes

+2 more reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@katiewasnothere katiewasnothere katiewasnothere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kiashok @jterry75 @kevpar @jsturtevant @katiewasnothere