update tar2ext4 package#1785
Merged
anmaxvl merged 2 commits intomicrosoft:mainfrom May 23, 2023
Merged
Conversation
helsaawy
approved these changes
May 18, 2023
Contributor
helsaawy
left a comment
helsaawy
left a comment
There was a problem hiding this comment.
Can you change w in ComputeAndWriteHashDevice from io.WriteSeeker to io.Writer, so its explicit that it just appends the hash to the current location, without seeking?
Or, if its exported, update the comments to specify that?
anmaxvl
force-pushed
the
tar2ext4-updates
branch
3 times, most recently
from
11ad2ee to
b67ce8e
Compare
helsaawy
approved these changes
May 18, 2023
anmaxvl
force-pushed
the
tar2ext4-updates
branch
3 times, most recently
from
0813a8c to
4c90763
Compare
anmaxvl
changed the title
Add another `ReadExt4SuperBlockReadSeeker` implementation to work with `io.ReadSeeker` in addition to working with files directly. This way we'll be able to work with e.g. ext4 GPT partitions. The existing `ReadExt4SuperBlock` works the same, but has been updated to call `ReadExt4SuperBlockReadSeeker`. Add `ReadDMVerityInfoReader` that reads dmverity superblock from an `io.Reader` and update `ReadDMVerityInfo` accordingly. Additionally write verity superblock directly without `io.SeekEnd`, assumming that the writer is already set at correct offset. `ComputeAndWriteHashDevice` parameters have been updated accordingly. Add `Ext4FileSystemSize` function that reads ext4 superblock from a given `io.ReadSeeker` and returns the underlying ext4 filesystem size and its superblock. Signed-off-by: Maksim An <[email protected]>
Signed-off-by: Maksim An <[email protected]>
katiewasnothere
approved these changes
May 22, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Add another `ReadExt4SuperBlockReadSeeker` implementation to work with `io.ReadSeeker` in addition to working with files directly. This way we'll be able to work with e.g. ext4 GPT partitions. The existing `ReadExt4SuperBlock` works the same, but has been updated to call `ReadExt4SuperBlockReadSeeker`. Add `ReadDMVerityInfoReader` that reads dmverity superblock from an `io.Reader` and update `ReadDMVerityInfo` accordingly. Additionally write verity superblock directly without `io.SeekEnd`, assumming that the writer is already set at correct offset. `ComputeAndWriteHashDevice` parameters have been updated accordingly. Add `Ext4FileSystemSize` function that reads ext4 superblock from a given `io.ReadSeeker` and returns the underlying ext4 filesystem size and its superblock. Signed-off-by: Maksim An <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add another
ReadExt4SuperBlockimplementatino to work withio.ReadSeekerin addition to working with files directly. This way we'll be able to work with e.g. ext4 GPT partitions.Additionally write verity superblock directly without
io.SeekEnd, assumming that the writer is already set at correct offset.