Merged
Conversation
Go already relies on its own internal caching, and replicating that in make adds unnecessary complexity, and is error prone, since the makefile doesn't recognize if new files are added, and isn't aware of build constraints. Remove `*.gomake` and `*.godeps` portion of makefile and invoke go directly. Remove `hack/gomakedeps.sh` file Signed-off-by: Hamza El-Saawy <[email protected]>
Contributor
|
Should we also remove the |
Contributor
Author
It can be safely deleted after this, though I think we probably should still keep the |
anmaxvl
approved these changes
May 4, 2023
helsaawy
added a commit
to helsaawy/hcsshim
that referenced
this pull request
May 4, 2023
Go already relies on its own internal caching, and replicating that in make adds unnecessary complexity, and is error prone, since the makefile doesn't recognize if new files are added, and isn't aware of build constraints. Remove `*.gomake` and `*.godeps` portion of makefile and invoke go directly. Remove `hack/gomakedeps.sh` file Signed-off-by: Hamza El-Saawy <[email protected]>
anmaxvl
pushed a commit
that referenced
this pull request
Oct 20, 2023
This PR updates our ADO fork to commits in hcsshim up to commit hash [7769a64](7769a64). This includes support for partitioned scsi devices and ensuring filesystem format for lcow scsi devices. Related work items: #1728, #1740, #1741, #1742, #1743, #1744, #1745, #1747, #1748, #1749, #1750, #1752, #1754, #1756, #1757, #1767, #1769, #1771, #1772, #1773, #1779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go already relies on its own internal caching, and replicating that in make adds unnecessary complexity, and is error prone, since the makefile doesn't recognize if new files are added, and isn't aware of build constraints.
Remove
*.gomakeand*.godepsportion of makefile and invoke go directly. Removehack/gomakedeps.shfile