Move oci/wclayer to internal for now #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may want to iterate on this interface a bit before we support it outside of hcsshim.
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Dec 19, 2020
Before microsoft#173, this was exposed as oci/wclayer, but there are already a few things named 'wclayer' in this project, and they all mean different things. See eb0cc25 Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Jan 2, 2021
Before microsoft#173, this was exposed as oci/wclayer, but there are already a few things named 'wclayer' in this project, and they all mean different things. See eb0cc25 Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Jan 2, 2021
Before microsoft#173, this was exposed as oci/wclayer, but there are already a few things named 'wclayer' in this project, and they all mean different things. See eb0cc25 Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Jan 10, 2021
Before microsoft#173, this was exposed as oci/wclayer, but there are already a few things named 'wclayer' in this project, and they all mean different things. See eb0cc25 Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Jan 12, 2021
This (re-)introduces ImportLayerFromTar and ExportLayerToTar into pkg/ociwclayer. Before microsoft#173, these APIS were exposed from oci/wclayer as ImportLayer and ExportLayer, but those names are too generic and already overloaded for similar but different meanings in this project. See eb0cc25 Signed-off-by: Paul "TBBle" Hampson <[email protected]>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
This (re-)introduces ImportLayerFromTar and ExportLayerToTar into pkg/ociwclayer. Before microsoft#173, these APIS were exposed from oci/wclayer as ImportLayer and ExportLayer, but those names are too generic and already overloaded for similar but different meanings in this project. See eb0cc25 Signed-off-by: Paul "TBBle" Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to iterate on this interface a bit before we support it
outside of hcsshim.