[release/0.9] Fix graceful termination test errors (#1687)#1695
Merged
kiashok merged 1 commit intomicrosoft:release/0.9from Mar 15, 2023
Merged
[release/0.9] Fix graceful termination test errors (#1687)#1695kiashok merged 1 commit intomicrosoft:release/0.9from
kiashok merged 1 commit intomicrosoft:release/0.9from
Conversation
ambarve
approved these changes
Mar 15, 2023
Contributor
ambarve
left a comment
ambarve
left a comment
There was a problem hiding this comment.
Looks like there are some test failures. Can you fix those before merging?
- Loosen the time interval check that measures the time taken to stop the container with -t command to account for cloud test delays - Add to check that OS version is V21H2Server since the graceful termination test images are based on servercore and nanoserver 2022. Signed-off-by: Kirtana Ashok <[email protected]> Co-authored-by: Kirtana Ashok <[email protected]> (cherry picked from commit 5e3a6df) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
force-pushed
the
portGracefulTermTestFix
branch
from
26cab91 to
8aa8c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports graceful termination test fix from main.
stop the container with -t command to account for cloud test delays
termination test images are based on servercore and nanoserver 2022.
(cherry picked from commit 5e3a6df)