Fix graceful termination test errors#1687
Merged
kiashok merged 1 commit intomicrosoft:mainfrom Mar 14, 2023
Merged
Conversation
kiashok
force-pushed
the
fixGracefulTerminationTestFailure
branch
3 times, most recently
from
bb37812 to
371cb71
Compare
anmaxvl
approved these changes
Mar 9, 2023
kiashok
force-pushed
the
fixGracefulTerminationTestFailure
branch
5 times, most recently
from
f10355c to
570171f
Compare
- Loosen the time interval check that measures the time taken to stop the container with -t command to account for cloud test delays - Add to check that OS version is V21H2Server since the graceful termination test images are based on servercore and nanoserver 2022. Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
force-pushed
the
fixGracefulTerminationTestFailure
branch
from
570171f to
8c397d3
Compare
ambarve
approved these changes
Mar 14, 2023
kiashok
added a commit
to kiashok/hcsshim
that referenced
this pull request
Mar 15, 2023
- Loosen the time interval check that measures the time taken to stop the container with -t command to account for cloud test delays - Add to check that OS version is V21H2Server since the graceful termination test images are based on servercore and nanoserver 2022. Signed-off-by: Kirtana Ashok <[email protected]> Co-authored-by: Kirtana Ashok <[email protected]> (cherry picked from commit 5e3a6df) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
added a commit
to kiashok/hcsshim
that referenced
this pull request
Mar 15, 2023
- Loosen the time interval check that measures the time taken to stop the container with -t command to account for cloud test delays - Add to check that OS version is V21H2Server since the graceful termination test images are based on servercore and nanoserver 2022. Signed-off-by: Kirtana Ashok <[email protected]> Co-authored-by: Kirtana Ashok <[email protected]> (cherry picked from commit 5e3a6df) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
added a commit
that referenced
this pull request
Mar 15, 2023
- Loosen the time interval check that measures the time taken to stop the container with -t command to account for cloud test delays - Add to check that OS version is V21H2Server since the graceful termination test images are based on servercore and nanoserver 2022. (cherry picked from commit 5e3a6df) Signed-off-by: Kirtana Ashok <[email protected]> Co-authored-by: Kirtana Ashok <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes test failures seen for graceful termination tests