[release/0.9] Remove blocking wait on container exit for every exec created#1604
Merged
kiashok merged 1 commit intomicrosoft:release/0.9from Dec 12, 2022
Merged
Conversation
anmaxvl
reviewed
Dec 12, 2022
Contributor
anmaxvl
left a comment
anmaxvl
left a comment
There was a problem hiding this comment.
nit: I think we could just do git cherry-pick -x <commit-hash>. you'd need to run go mod tidy && go mod vendor in the test directory. I think 0.9.x is still using vendoring in test.
Commit fixes the memory leak seen in the shim. It removes creation of channel that waits on container exit for every new exec. Instead, the container wait channel is exposed through WaitChannel() function which callers can use to decide if container has exited or not. Signed-off-by: Kirtana Ashok <[email protected]> (cherry picked from commit 5fc00c5) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
force-pushed
the
memLeakFixPort
branch
from
8f1cb80 to
cb19393
Compare
anmaxvl
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is porting fix with commit hash 5fc00c5 from hcsshim/main to hcsshim release/0.9 branch
Commit fixes the memory leak seen in the shim.
It removes creation of channel that waits on container exit for every new exec. Instead, the container wait channel is exposed through WaitChannel() function which callers can use to decide if container has exited or not.
Signed-off-by: Kirtana Ashok [email protected]