Add IO tracking option for job objects#1459
Merged
dcantah merged 2 commits intomicrosoft:masterfrom Jul 20, 2022
Merged
Conversation
helsaawy
requested changes
Jul 19, 2022
dcantah
force-pushed
the
fix-hpc-storage-stats
branch
from
c4c4aee to
19a7223
Compare
HCS enables this to get more in depth IO stats for the silo of the
container. I'd swapped hostprocess containers to querying for
these stats but without the prerequisite of actually enabling them :)
This change adds a new option on jobobject.Options{} to enable this
functionality and adds a new test to ensure we can actually call
StorageStats now.
Signed-off-by: Daniel Canter <[email protected]>
- Add test to ensure IO tracking needs to be enabled or querying for storage stats will return an error. - Make wording on what needs to be toggled for querying storage stats more clear. Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
fix-hpc-storage-stats
branch
from
19a7223 to
01a65f3
Compare
helsaawy
approved these changes
Jul 19, 2022
kiashok
approved these changes
Jul 20, 2022
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
Jul 21, 2022
* Add IO tracking option for job objects
HCS enables this to get more in depth IO stats for the silo of the
container. I'd swapped hostprocess containers to querying for
these stats but without the prerequisite of actually enabling them :)
This change adds a new option on jobobject.Options{} to enable this
functionality and adds a new test to ensure we can actually call
StorageStats now.
Signed-off-by: Daniel Canter <[email protected]>
(cherry picked from commit 598ea47)
Signed-off-by: Daniel Canter <[email protected]>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Add IO tracking option for job objects
HCS enables this to get more in depth IO stats for the silo of the
container. I'd swapped hostprocess containers to querying for
these stats but without the prerequisite of actually enabling them :)
This change adds a new option on jobobject.Options{} to enable this
functionality and adds a new test to ensure we can actually call
StorageStats now.
Signed-off-by: Daniel Canter <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HCS enables this to get more in depth IO stats for the silo of the
container, and is what is returned when asking for stats for the container.
I'd swapped hostprocess containers to querying for these stats, but without
the prerequisite of actually enabling them :)
This change adds a new option on jobobject.Options{} to enable this
functionality and adds a new test to ensure we can actually call
StorageStats now (It would return Element Not Found previously).