fix shared scratch scenario#1435
Merged
anmaxvl merged 1 commit intomicrosoft:masterfrom Jun 17, 2022
Merged
Conversation
When mounting container layers we override containerScratchPathInUVM with scsiMount.UVMPath after calling into vm.AddSCSI(...), which is fine in scenarios when scratch disk isn't shared. In case when scratch sharing is enabled, the scsiMount returned has sandbox container's scratch path and we end up mounting all of the workload containers' overlay at `/run/gcs/c/<podid>/container_<podid>` instead of `/run/gcs/c/<podid>/container_<cid1>` and `/run/gcs/c/<podid>/container_<cid2>`. Fix by removing the unnecessary assignment. Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
shared-scratch-fixes
branch
from
0d0249d to
b703c6e
Compare
helsaawy
approved these changes
Jun 17, 2022
katiewasnothere
approved these changes
Jun 17, 2022
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Jul 11, 2022
When mounting container layers we override containerScratchPathInUVM with scsiMount.UVMPath after calling into vm.AddSCSI(...), which is fine in scenarios when scratch disk isn't shared. In case when scratch sharing is enabled, the scsiMount returned has sandbox container's scratch path and we end up mounting all of the workload containers' overlay at `/run/gcs/c/<podid>/container_<podid>` instead of `/run/gcs/c/<podid>/container_<cid1>` and `/run/gcs/c/<podid>/container_<cid2>`. Fix by removing the unnecessary assignment. Signed-off-by: Maksim An <[email protected]>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
When mounting container layers we override containerScratchPathInUVM with scsiMount.UVMPath after calling into vm.AddSCSI(...), which is fine in scenarios when scratch disk isn't shared. In case when scratch sharing is enabled, the scsiMount returned has sandbox container's scratch path and we end up mounting all of the workload containers' overlay at `/run/gcs/c/<podid>/container_<podid>` instead of `/run/gcs/c/<podid>/container_<cid1>` and `/run/gcs/c/<podid>/container_<cid2>`. Fix by removing the unnecessary assignment. Signed-off-by: Maksim An <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mounting container layers we override containerScratchPathInUVM
with scsiMount.UVMPath after calling into vm.AddSCSI(...), which is
fine in scenarios when scratch disk isn't shared. In case when scratch
sharing is enabled, the scsiMount returned has sandbox container's
scratch path and we end up mounting all of the workload containers'
overlay at
/run/gcs/c/<podid>/container_<podid>instead of/run/gcs/c/<podid>/container_<cid1>and/run/gcs/c/<podid>/container_<cid2>.Fix by removing the unnecessary assignment.
Signed-off-by: Maksim An [email protected]