Skip to content

Don't use unsafe.Sizeof where encoding/binary.Size suffices #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmaxvl merged 1 commit into from
May 20, 2022
Merged

Don't use unsafe.Sizeof where encoding/binary.Size suffices #1404

anmaxvl merged 1 commit into from
May 20, 2022

Conversation

@edef1c
Copy link
Contributor

@edef1c edef1c commented May 19, 2022

unsafe.Sizeof depends on ABI details, but we're not actually using the raw memory layout of dmveritySuperblock. We're just writing it out with encoding/binary.Write, so encoding/binary.Size gives the relevant size.

@edef1c edef1c requested a review from a team as a code owner May 19, 2022 19:11
@ghost
Copy link

ghost commented May 19, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@edef1c
Don't use unsafe.Sizeof where encoding/binary.Size suffices
9ef6876 
unsafe.Sizeof depends on ABI details, but we're not actually using the
raw memory layout of dmveritySuperblock. We're just writing it out with
encoding/binary.Write, so encoding/binary.Size gives the relevant size.

Signed-off-by: edef <[email protected]>
@anmaxvl anmaxvl merged commit be02f1d into microsoft:master May 20, 2022
@edef1c edef1c deleted the dm-verity-unsafe branch May 20, 2022 21:02
anmaxvl added a commit that referenced this pull request Feb 7, 2023
@anmaxvl
Merged PR 6117553: Sync ADO to 671ec23
6342f80 
Sync ADO to 671ec23

Related work items: #1258, #1273, #1304, #1359, #1360, #1362, #1363, #1367, #1372, #1374, #1377, #1380, #1381, #1382, #1384, #1387, #1388, #1389, #1390, #1391, #1393, #1394, #1395, #1396, #1398, #1400, #1401, #1402, #1404, #1406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmaxvl anmaxvl anmaxvl approved these changes

@helsaawy helsaawy helsaawy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edef1c @anmaxvl @helsaawy