Add _test suffix #1395
Merged
Add _test suffix #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hamza El-Saawy <[email protected]>
Contributor
|
I think thats because this wasn't a go test binary as much as it was a LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several
test\cri-containerdfiles do not end with_test, which presents issues with the language server.Additionally, if
test\go.modis removed, andtestbecomes part of thehcsshimmodule, then these files' dependencies would not be categorized as test dependencies.Additionally, since these files contained testing helper functions, they are prepended with
helper_to better identify them.Signed-off-by: Hamza El-Saawy [email protected]