Unset text attribute for vendored files in gitattributes #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
approved these changes
May 10, 2022
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
gitattributes_update
branch
from
fae5445 to
521aae8
Compare
dcantah
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues in the
verify-test-vendorci job seen in #1351 where a file was vendored with a crlf line ending but due to our git attributes settings, the file was pushed with lf line endings. This causes a file difference when checking if the modules are out of date in the ci job.Signed-off-by: Kathryn Baldauf [email protected]