Skip to content

Bridge rpcProc string conversion #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
helsaawy merged 1 commit into from
May 9, 2022
Merged

Bridge rpcProc string conversion #1391

helsaawy merged 1 commit into from
May 9, 2022

Conversation

@helsaawy
Copy link
Contributor

@helsaawy helsaawy commented May 9, 2022

Factored internal/gcs.(rpcProc).String() method out from internal/gcs.(msgType).String()

This is needed for PR #1379

Signed-off-by: Hamza El-Saawy [email protected]

@helsaawy
rpc string conversion
e35976a 
Signed-off-by: Hamza El-Saawy <[email protected]>
@helsaawy helsaawy requested a review from a team as a code owner May 9, 2022 17:36
@helsaawy helsaawy mentioned this pull request May 9, 2022
Draft
ambarve
ambarve approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@ambarve ambarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@helsaawy helsaawy merged commit ebe034c into microsoft:master May 9, 2022
@helsaawy helsaawy deleted the he/bridge-string branch May 9, 2022 19:29
anmaxvl added a commit that referenced this pull request Feb 7, 2023
@anmaxvl
Merged PR 6117553: Sync ADO to 671ec23
6342f80 
Sync ADO to 671ec23

Related work items: #1258, #1273, #1304, #1359, #1360, #1362, #1363, #1367, #1372, #1374, #1377, #1380, #1381, #1382, #1384, #1387, #1388, #1389, #1390, #1391, #1393, #1394, #1395, #1396, #1398, #1400, #1401, #1402, #1404, #1406
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@helsaawy
rpc string conversion (microsoft#1391)
8e6bea6 
Signed-off-by: Hamza El-Saawy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmaxvl anmaxvl anmaxvl approved these changes

@ambarve ambarve ambarve approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@helsaawy @anmaxvl @ambarve