tests: add tests for wait-paths #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up PR to add tests for wait-paths after initial PR microsoft#1258 was merged. Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
tests/wait-paths
branch
from
b251300 to
296c002
Compare
helsaawy
reviewed
May 2, 2022
Contributor
helsaawy
left a comment
helsaawy
left a comment
There was a problem hiding this comment.
Just a couple concerns with the tests, but no major issues.
| } | ||
| }() | ||
|
|
||
| if err := <-errChan; err != nil { |
Contributor
There was a problem hiding this comment.
as a weird edge case, if app.Run() returns nil before the create file go routines runs, this will succeed, and then not only will any errors from os.Create be ignored, but errChan <- err will panic.
There was a problem hiding this comment.
Another edge case: app.Run() returns an error and we close the error channel before the subroutine to create the files runs/finishes running. We may end up causing a panic by writing to a closed chan.
Contributor
Author
There was a problem hiding this comment.
lmk if the updated implementation works for you.
|
couple comments in line with Hamza's review, otherwise looks good |
Signed-off-by: Maksim An <[email protected]>
helsaawy
approved these changes
May 3, 2022
katiewasnothere
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to add tests for wait-paths after initial PR #1258
was merged.
Signed-off-by: Maksim An [email protected]