Skip to content

Missing build constraint, doc.go #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
helsaawy merged 1 commit into from
Apr 27, 2022
Merged

Missing build constraint, doc.go #1381

helsaawy merged 1 commit into from
Apr 27, 2022

Conversation

@helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Apr 27, 2022

Signed-off-by: Hamza El-Saawy [email protected]

@helsaawy
Missing constraint, doc.go
668f499 
Signed-off-by: Hamza El-Saawy <[email protected]>
@helsaawy helsaawy requested a review from a team as a code owner April 27, 2022 20:36
katiewasnothere
katiewasnothere reviewed Apr 27, 2022
View reviewed changes
katiewasnothere
katiewasnothere approved these changes Apr 27, 2022
View reviewed changes
Copy link

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@helsaawy helsaawy merged commit 24d4866 into microsoft:master Apr 27, 2022
@helsaawy helsaawy deleted the he/missing-constraint branch April 27, 2022 20:57
anmaxvl added a commit that referenced this pull request Feb 7, 2023
@anmaxvl
Merged PR 6117553: Sync ADO to 671ec23
6342f80 
Sync ADO to 671ec23

Related work items: #1258, #1273, #1304, #1359, #1360, #1362, #1363, #1367, #1372, #1374, #1377, #1380, #1381, #1382, #1384, #1387, #1388, #1389, #1390, #1391, #1393, #1394, #1395, #1396, #1398, #1400, #1401, #1402, #1404, #1406
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@helsaawy
Missing constraint, doc.go (microsoft#1381)
3bad2a6 
Signed-off-by: Hamza El-Saawy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@katiewasnothere katiewasnothere katiewasnothere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@helsaawy @katiewasnothere