Random fixes broken out of base layer work #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
approved these changes
Apr 26, 2022
dcantah
reviewed
Apr 27, 2022
dcantah
approved these changes
Apr 27, 2022
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
LGTM, one bit of feedback on the safefile commit.
Signed-off-by: Paul "TBBle" Hampson <[email protected]>
Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
force-pushed
the
random-fixes-broken-out-of-base-layer-work
branch
2 times, most recently
from
716a82d to
f68596e
Compare
Signed-off-by: Paul "TBBle" Hampson <[email protected]>
Signed-off-by: Paul "TBBle" Hampson <[email protected]>
I also sorted the archive step list of binaries to match the calls to `go build` so that it's clear when a binary has been overlooked. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
force-pushed
the
random-fixes-broken-out-of-base-layer-work
branch
from
f68596e to
be9ebd6
Compare
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small batch of fixes that I've broken out of #901 to reduce the scope of that PR to only those parts that introduce not-yet-acceptible features.
This reduces the depth of the branches I have to manage and rebase.
Mostly documentation and CI, but also introduces a new SafeOpen API used by #901.