Swap to fmt.Errorf in jobobject package #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change swaps to fmt.Errorf for wrapped errors in the jobobject package from errors.Wrap. We'd had talks of moving this code to winio where we've removed our pkg/errors dependency so this would make the port easier. Signed-off-by: Daniel Canter <[email protected]>
anmaxvl
approved these changes
Apr 14, 2022
helsaawy
requested changes
Apr 14, 2022
Contributor
helsaawy
left a comment
helsaawy
left a comment
There was a problem hiding this comment.
I can't comment on them, but can you replace the "github.com/pkg/errors" imports with the vanilla "errors" as well?
Contributor
Author
Oh good call |
Swap imports to "errors" for errors.New usage also Signed-off-by: Daniel Canter <[email protected]>
Contributor
Author
|
@helsaawy Done |
helsaawy
approved these changes
Apr 14, 2022
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
May 19, 2022
* Swap to fmt.Errorf in jobobject package This change swaps to fmt.Errorf for wrapped errors in the jobobject package from errors.Wrap. We'd had talks of moving this code to winio where we've removed our pkg/errors dependency so this would make the port easier. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit ccec73f) Signed-off-by: Daniel Canter <[email protected]>
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Swap to fmt.Errorf in jobobject package This change swaps to fmt.Errorf for wrapped errors in the jobobject package from errors.Wrap. We'd had talks of moving this code to winio where we've removed our pkg/errors dependency so this would make the port easier. Signed-off-by: Daniel Canter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change swaps to fmt.Errorf for wrapped errors in the jobobject package from errors.Wrap. We'd had talks of moving this code to winio where we've removed our pkg/errors dependency so this would make the port easier.
We should probably do this for most things to see if we can get rid of our pkg/errors use, the only thing I'm not sure on is we use the stack embedding errors.Wrap provides for the gcs https://github.com/microsoft/hcsshim/blob/master/internal/guest/gcserr/errors.go#L57-L88