Port grantvmgroupaccess code from go-winio and extend functionality. #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterry75
reviewed
Apr 7, 2022
jterry75
reviewed
Apr 7, 2022
jterry75
reviewed
Apr 7, 2022
anmaxvl
force-pushed
the
port-grantvmgroupaccess-code
branch
3 times, most recently
from
af0fd42 to
a4bcc87
Compare
jterry75
reviewed
Apr 7, 2022
helsaawy
reviewed
Apr 8, 2022
anmaxvl
force-pushed
the
port-grantvmgroupaccess-code
branch
6 times, most recently
from
acc6a86 to
a5cc184
Compare
helsaawy
approved these changes
Apr 11, 2022
anmaxvl
force-pushed
the
port-grantvmgroupaccess-code
branch
from
25b45d1 to
bd278ed
Compare
katiewasnothere
approved these changes
Apr 22, 2022
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
small nit in the tests, otherwise LGTM
Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
port-grantvmgroupaccess-code
branch
2 times, most recently
from
cf033f5 to
9f020aa
Compare
Add masks for GENERIC_WRITE, GENERIC_EXECUTE and GENERIC_ALL and update function signatures accordingly. Update grantvmgroupaccess tool to support granting permissions from above. Ignore various linter errors resurfaced after code copy-paste. Remove mksyscall_windows.go and update old unit tests and cleanup helper functions and packages used. Add unit test coverage for new functionality. Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
port-grantvmgroupaccess-code
branch
from
9f020aa to
6b92044
Compare
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally suggested here microsoft/go-winio#243
port
go-winio/pkg/securitycode into hcsshim repo and further extend thepackage and tooling code to support setting other access permissions like
GENERIC_WRITE,GENERIC_EXECUTE,GENERIC_ALLand their combinations.grantvmgroupaccesstool now supports various boolean flags to setaforementioned permissions.