Skip to content

Removed shim publisher dependence on global flag/setting #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
helsaawy merged 1 commit into from
Apr 15, 2022
Merged

Removed shim publisher dependence on global flag/setting #1343

helsaawy merged 1 commit into from
Apr 15, 2022

Conversation

@helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Apr 4, 2022

Shim eventPublisher now uses an internal setting for the namespace instead of relying on a global flag.

Signed-off-by: Hamza El-Saawy [email protected]

@helsaawy helsaawy requested a review from a team as a code owner April 4, 2022 21:14
@dcantah dcantah mentioned this pull request Apr 4, 2022
Merged
katiewasnothere
katiewasnothere approved these changes Apr 15, 2022
View reviewed changes
Copy link

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75
Copy link
Contributor

jterry75 commented Apr 15, 2022

Why did CRI not hit this before since its all in custom namespaces? I'm surprised the events ever worked globally. Were they just matching any global event by type id?

@helsaawy
Copy link
Contributor Author

helsaawy commented Apr 15, 2022

Why did CRI not hit this before since its all in custom namespaces? I'm surprised the events ever worked globally. Were they just matching any global event by type id?

This (should?) have worked properly originally, its just that we were reading a global flag every time we published, which seemed bad.

@helsaawy helsaawy merged commit 2baf93b into microsoft:master Apr 15, 2022
@helsaawy helsaawy deleted the he/publisher branch April 15, 2022 16:25
@jterry75
Copy link
Contributor

jterry75 commented Apr 15, 2022

Oh lol. Misread the code. Yes I see that now, good fix

anmaxvl added a commit that referenced this pull request Feb 7, 2023
@anmaxvl
Merged PR 5999316: Update ADO to dbb347e
437abac 
Sync ADO with upstream to enable including test GCS binaries as
part of dev-pipeline

Related work items: #1311, #1322, #1341, #1343, #1345, #1347, #1348, #1350, #1353, #1354, #1355, #1358, #1361, #1365, #1368, #1369, #1370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@katiewasnothere katiewasnothere katiewasnothere approved these changes

@dcantah dcantah dcantah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@katiewasnothere katiewasnothere

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@helsaawy @jterry75 @katiewasnothere @dcantah