Support for multiple SCSI controllers #1328

ambarve · 2022-03-14T16:26:21Z

Enable using upto 4 SCSI controllers for LCOW UVMs. HCS currently doesn't respect the
SCSI controller number provided with the Add SCSI disk requests. Hence, the SCSI disk can
show up at some different controller inside the LCOW UVM. To avoid this, now we use GUIDs
to represent each controller and use that GUID with the Add SCSI disk request.
GCS code is also modified to identify the controller number from the controller GUID.

Signed-off-by: Amit Barve [email protected]

Enable using upto 4 SCSI controllers for LCOW UVMs. HCS currently doesn't respect the SCSI controller number provided with the Add SCSI disk requests. Hence, the SCSI disk can show up at some different controller inside the LCOW UVM. To avoid this, now we use GUIDs to represent each controller and use that GUID with the Add SCSI disk request. GCS code is also modified to identify the controller number from the controller GUID. Signed-off-by: Amit Barve <[email protected]>

Signed-off-by: Amit Barve <[email protected]>

cmd/runhcs/create-scratch.go

internal/protocol/guestresource/resources.go

internal/uvm/create_lcow.go

internal/uvm/create_wcow.go

test/cri-containerd/disable_vpmem_test.go

internal/uvm/constants.go

internal/uvm/create_lcow.go

internal/guest/storage/scsi/scsi.go

internal/uvm/constants.go

Use Camel case for GUID array, include comment above each GUID to make it easier to search. Add a check to make sure WCOW is never created with zero SCSI controllers. Signed-off-by: Amit Barve <[email protected]>

internal/guest/storage/scsi/scsi.go

internal/uvm/constants.go

Earlier changes to support several SCSI controllers modified the GCS protocol. This commit modifies the code to keep the same GCS protocol and maintain the list of controller GUIDs inside GCS. Signed-off-by: Amit Barve <[email protected]>

internal/uvm/create.go

Also, enable 4 SCSI controllers on LCOW only if no vpmem multimapping is enabled. Signed-off-by: Amit Barve <[email protected]>

Signed-off-by: Amit Barve <[email protected]>

internal/uvm/create_lcow.go

test/cri-containerd/disable_vpmem_test.go

internal/uvm/create.go

Earlier we had disabled VPMEM devices for container layer but the UVM was still using VPMEM for rootfs. This commit changes that and forces the UVM to use initrd for rootfs. Also, adds an error if SCSI controller count for WCOW is not set to 1. Signed-off-by: Amit Barve <[email protected]>

Signed-off-by: Amit Barve <[email protected]>

test/cri-containerd/disable_vpmem_test.go

internal/protocol/guestrequest/types.go

Signed-off-by: Amit Barve <[email protected]>

ambarve · 2022-03-28T21:27:07Z

@kevpar , @dcantah & @anmaxvl Can you PTAL?

kevpar

LGTM

anmaxvl

LGTM

dcantah

LGTM

Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337

* Support for multiple SCSI controllers Enable using upto 4 SCSI controllers for LCOW UVMs. HCS currently doesn't respect the SCSI controller number provided with the Add SCSI disk requests. Hence, the SCSI disk can show up at some different controller inside the LCOW UVM. To avoid this, now we use GUIDs to represent each controller and use that GUID with the Add SCSI disk request. GCS code is also modified to identify the controller number from the controller GUID. Now if a LCOW pod is created with an annotation that sets VPMEM device count to 0, we will automatically enable 4 SCSI controllers. Even the rootfs.vhd will be attached via SCSI in that scenario. Signed-off-by: Amit Barve <[email protected]>

ambarve requested a review from a team as a code owner March 14, 2022 16:26

ambarve mentioned this pull request Mar 14, 2022

Support multi scsi controllers #1323

Closed

ambarve added 2 commits March 14, 2022 09:34

Add test and go mod vendor

ab2f28d

Signed-off-by: Amit Barve <[email protected]>

ambarve force-pushed the scsi_controller_guid branch from ac09f58 to ab2f28d Compare March 14, 2022 16:34

ambarve marked this pull request as draft March 14, 2022 17:09

Update create scratch code to keep SCSI controllers to 1

9883272

Signed-off-by: Amit Barve <[email protected]>

ambarve force-pushed the scsi_controller_guid branch from 132cd5d to 9883272 Compare March 14, 2022 22:29

ambarve marked this pull request as ready for review March 14, 2022 22:30

Fix scsi tests

a953641

Signed-off-by: Amit Barve <[email protected]>