Add tests for security policy enforcement #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
force-pushed
the
tests/basic-security-policy-tests
branch
from
cc2bd61 to
1c2ea78
Compare
anmaxvl
commented
Mar 16, 2022
ambarve
approved these changes
Apr 6, 2022
Contributor
ambarve
left a comment
ambarve
left a comment
There was a problem hiding this comment.
Minor comment but otherwise LGTM!
helsaawy
approved these changes
Apr 6, 2022
Contributor
helsaawy
left a comment
helsaawy
left a comment
There was a problem hiding this comment.
I also agree with Amit that configOpt and co should be part of securitypolicy. But otherwise, LGTM
anmaxvl
force-pushed
the
tests/basic-security-policy-tests
branch
2 times, most recently
from
17307b5 to
29f6c8f
Compare
Contributor
|
Linters failing as some of the go tooling didn't have support for 1.18, and ^1.17.0 is resolving to 1.18 now in our CI. golangci/golangci-lint#2438 |
Add basic positive and negative tests for security policy enforcement. Signed-off-by: Maksim An <[email protected]>
Signed-off-by: Maksim An <[email protected]>
Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
tests/basic-security-policy-tests
branch
from
29f6c8f to
77e0f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic positive and negative tests for security policy enforcement.
Signed-off-by: Maksim An [email protected]