fix lint issue #1314
Merged
fix lint issue #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim An <[email protected]>
Contributor
Author
|
@dcantah PTAL 😄 all PRs are failing because of this, maybe we should just fix in a separate PR (this one). |
Contributor
|
I'll try and look into why it seems like some make it through fine.. I'm trying to reason with how the actual pr that introduced this didn't run into anything. I'd even just rebased a previous pr on top of master (that has this change that it's whining about) and the linter didn't complain |
Contributor
Author
|
so, it gets triggered on a branch in the main repo... like in the dependapot PR. but not caught on PRs from forks. maybe something wonky there. |
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Maksim An <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maksim An [email protected]