Skip to content

Conversation

@dcantah
Copy link
Contributor

@dcantah dcantah commented Feb 17, 2022

Most of the code in /internal/guest has build tags as it's all Linux specific
so apply one for vsock.go as well as vsock.Dial is unimplemented on Windows.

This also fixes a linter issue we've been seeing on the push trigger for
golangci-lint. It complains that the error check we're performing can
never be true (err == nil) because on linting this file with GOOS=windows
it will check the Windows implementation for vsock.Dial which is hard coded
to return an unimplemented error.

Most of the code in /internal/guest has build tags as it's all Linux specific
so apply one for vsock.go as well as vsock.Dial is unimplemented on Windows.

This also fixes a linter issue we've been seeing on the push trigger for
golangci-lint. It complains that the error check we're performing can
never be true (err == nil) because on linting this file with GOOS=windows
it will check the Windows implementation for vsock.Dial which is hard coded
to return an unimplemented error always.

Signed-off-by: Daniel Canter <[email protected]>
@dcantah dcantah requested a review from a team as a code owner February 17, 2022 21:51
@dcantah dcantah merged commit bb3403c into microsoft:master Feb 18, 2022
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
…1301)

Most of the code in /internal/guest has build tags as it's all Linux specific
so apply one for vsock.go as well as vsock.Dial is unimplemented on Windows.

This also fixes a linter issue we've been seeing on the push trigger for
golangci-lint. It complains that the error check we're performing can
never be true (err == nil) because on linting this file with GOOS=windows
it will check the Windows implementation for vsock.Dial which is hard coded
to return an unimplemented error always.

Signed-off-by: Daniel Canter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants