Skip to content

Fix bugs in network setup introduced by a refactor PR #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmaxvl merged 1 commit into from
Feb 15, 2022
Merged

Fix bugs in network setup introduced by a refactor PR #1299

anmaxvl merged 1 commit into from
Feb 15, 2022

Conversation

@anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Feb 15, 2022

When consolidating guest protocol into its own package
in #1240 wrong constant
definition was used for adding a network namespace. Fix this by
using the correct constants.

Signed-off-by: Maksim An [email protected]

@anmaxvl
Fix bugs in network setup introduced by a refactor PR
467dba1 
When consolidating guest protocol into its own package
in microsoft#1240 wrong constant
definition was used for adding a network namespace. Fix this by
using the correct constants.

Signed-off-by: Maksim An <[email protected]>
@anmaxvl anmaxvl requested a review from a team as a code owner February 15, 2022 20:57
ambarve
ambarve approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@ambarve ambarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmaxvl anmaxvl merged commit 12b02a1 into microsoft:master Feb 15, 2022
@anmaxvl anmaxvl deleted the fix-refactor-bugs branch February 15, 2022 22:02
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@anmaxvl
Fix bugs in network setup introduced by a refactor PR (microsoft#1299)
c867428 
When consolidating guest protocol into its own package
in microsoft#1240 wrong constant
definition was used for adding a network namespace. Fix this by
using the correct constants.

Signed-off-by: Maksim An <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambarve ambarve ambarve approved these changes

+1 more reviewer

@dcantah dcantah dcantah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ambarve ambarve

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anmaxvl @dcantah @ambarve