Expand env variables for job containers to job mount path #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jsturtevant Sweet sweet. CI's whining about no sign-off btw. |
When installing tools into container it is sometimes desirable to have those tools on the path for the current process. Since the Windows doesn't support variable expansion on the PATH variable and the job mount path as something that isn't know at runtime we need to expand it for the passer. This could go away if the mount path is no longer used in the future. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
expand-job-envs
branch
from
641dcb5 to
014849a
Compare
Contributor
Author
sorry I need to set this up so it's automatic |
dcantah
approved these changes
Feb 3, 2022
jsturtevant
force-pushed
the
expand-job-envs
branch
from
79918fd to
28ad804
Compare
dcantah
reviewed
Feb 4, 2022
dcantah
approved these changes
Feb 4, 2022
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
lgtm again, minor comment
jsturtevant
force-pushed
the
expand-job-envs
branch
from
28ad804 to
ab02eb0
Compare
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
expand-job-envs
branch
from
ab02eb0 to
9d05b5b
Compare
anmaxvl
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing tools into container it is sometimes desirable to have
those tools on the path for the current process. Since the Windows
doesn't support variable expansion on the PATH variable and the
job mount path as something that isn't know at runtime we need to expand
it for the passer. This could go away if the mount path is no longer
used in the future.
A sample docker file where this would work:
cc: @dcantah