Skip to content

shim: Don't shadow err return in createPod #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevpar merged 1 commit into from
Feb 1, 2022
Merged

shim: Don't shadow err return in createPod #1288

kevpar merged 1 commit into from
Feb 1, 2022

Conversation

@kevpar
Copy link
Member

@kevpar kevpar commented Feb 1, 2022

Correctly uses a named return value on createPod. Previously if err was
redeclared in a nested scope and then returned, defers would not see the
returned error value. In particular this prevented the UVM cleanup defer
from working properly.

Signed-off-by: Kevin Parsons [email protected]

@kevpar
shim: Don't shadow err return in createPod
a7ef153 
Correctly uses a named return value on createPod. Previously if err was
redeclared in a nested scope and then returned, defers would not see the
returned error value. In particular this prevented the UVM cleanup defer
from working properly.

Signed-off-by: Kevin Parsons <[email protected]>
@kevpar kevpar requested a review from a team as a code owner February 1, 2022 22:36
dcantah
dcantah approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to assume CI will be happy here

@kevpar kevpar merged commit 95e0bcc into master Feb 1, 2022
@helsaawy helsaawy deleted the createpod-err-shadow branch May 23, 2022 20:32
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmaxvl anmaxvl anmaxvl approved these changes

+1 more reviewer

@dcantah dcantah dcantah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevpar @anmaxvl @dcantah