Tests for task and sandbox reset/restart #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
reviewed
Apr 18, 2022
Adds tests for resetting tasks and containers explicitly with CRI plugin API, and implicitly using annotations and start/stop commands. PR relies on accompanying CRI PR (kevpar/cri#13) being merged. Signed-off-by: Hamza El-Saawy <[email protected]>
helsaawy
force-pushed
the
he/restarttest
branch
from
e237408 to
43c0566
Compare
Contributor
Author
|
Rebased to resolve conflicts |
anmaxvl
approved these changes
Apr 19, 2022
Contributor
anmaxvl
left a comment
anmaxvl
left a comment
There was a problem hiding this comment.
a few nits, but otherwise LGTM
helsaawy
force-pushed
the
he/restarttest
branch
from
43c0566 to
bcc215b
Compare
Signed-off-by: Hamza El-Saawy <[email protected]>
katiewasnothere
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for resetting tasks and containers explicitly with CRI plugin API, and implicitly using annotations and start/stop commands, as well as state being preserved in sandbox VHD across container and pod restart.
Restart functionality implemented in:
kevpar/cri#13
#1271
#1316
Signed-off-by: Hamza El-Saawy [email protected]